Bug 42565 - Unbreak games/xpuyopuyo after GNOMENG mass commit
Summary: Unbreak games/xpuyopuyo after GNOMENG mass commit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-08 23:40 UTC by Tilman Linneweh
Modified: 2002-09-09 02:28 UTC (History)
1 user (show)

See Also:

Attachments
xpuyopuyo.diff (716 bytes, patch)
2002-09-08 23:40 UTC, Tilman Linneweh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tilman Linneweh 2002-09-08 23:40:06 UTC 
	This port needs GTK even if build WITHOUT_GNOME,
	If build with GNOME, it looks for gnome-config -> it needs gnomelibs
	DATADIR PLIST_SUB isn't defined in bsd.gnomeng.mk anymore.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-09-08 23:41:48 UTC 
Responsible Changed
From-To: freebsd-ports->marcus

I'll take this.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-09-08 23:46:39 UTC 
Wouldn't you rather conditionalize the PLIST_SUB on whether or not GNOME
is available?  For example:

.if ${HAVE_GNOME:Mgnomelibs}!=""
USE_GNOME+=	gnomehack gnomelibs
PKGNAMESUFFIX=	-gnome
PLIST_SUB+=	DATADIR="share/gnome"
.else
PLIST_SUB+=	DATADIR="share"
.endif

Joe
-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	marcus@FreeBSD.org
http://www.FreeBSD.org/gnome
Comment 3 Tilman Linneweh 2002-09-09 00:10:08 UTC 
Hi,

* Joe Marcus Clarke <marcus@FreeBSD.org> [08 Sep 2002 18:46:39 -0400]:

> Wouldn't you rather conditionalize the PLIST_SUB on whether or not GNOME
> is available?  For example:

Yeah, thats the way the old port behaved. 

> .if ${HAVE_GNOME:Mgnomelibs}!=""
> USE_GNOME+=	gnomehack gnomelibs
> PKGNAMESUFFIX=	-gnome
> PLIST_SUB+=	DATADIR="share/gnome"
> .else
> PLIST_SUB+=	DATADIR="share"
> .endif

Thanks && regards
arved
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-09-09 02:27:45 UTC 
State Changed
From-To: open->closed

Committed, thanks.