Bug 43408 - graphics/mpeg2play does not install documentation
Summary: graphics/mpeg2play does not install documentation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-27 03:40 UTC by Greg Lehey
Modified: 2003-05-19 16:53 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Lehey 2002-09-27 03:40:01 UTC
	The graphics/mpeg2play port does not install any documentation.

Fix: 

The problem is, of course, that the port barely has any
	documentation.  There is README, however; this should be
	installed in /usr/share/doc/mpeg2play.
How-To-Repeat: 	cd /usr/ports/graphics/mpeg2play
	make install
Comment 1 dirk.meyer 2003-05-18 09:19:51 UTC
This patch installs the README, if NOPORTDOCS is not defined.
any objections to commit this?

kind regards Dirk

- Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
- [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/multimedia/mpeg2play/Makefile,v
retrieving revision 1.10
diff -u -r1.10 Makefile
--- Makefile	4 Apr 2003 01:38:38 -0000	1.10
+++ Makefile	18 May 2003 08:17:36 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	mpeg2play
 PORTVERSION=	1.1b
+PORTREVISION=	1
 CATEGORIES=	multimedia
 MASTER_SITES=	ftp://ftp.funet.fi/pub/graphics/packages/mpeg/mpeg2play/
 
@@ -20,5 +21,9 @@
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/mpeg2play ${PREFIX}/bin
 	${INSTALL_DATA} ${WRKSRC}/Mpeg2play ${PREFIX}/lib/X11/app-defaults
+.if !defined(NOPORTDOCS)
+	${MKDIR} ${DOCSDIR}
+	${CP} ${WRKSRC}/README ${DOCSDIR}/README
+.endif
 
 .include <bsd.port.mk>
Index: pkg-plist
===================================================================
RCS file: /home/pcvs/ports/multimedia/mpeg2play/pkg-plist,v
retrieving revision 1.2
diff -u -r1.2 pkg-plist
--- pkg-plist	12 Aug 1997 06:56:30 -0000	1.2
+++ pkg-plist	18 May 2003 08:17:36 -0000
@@ -1,2 +1,4 @@
 bin/mpeg2play
 lib/X11/app-defaults/Mpeg2play
+%%PORTDOCS%%share/doc/mpeg2play/README
+%%PORTDOCS%%@dirrm share/doc/mpeg2play
Comment 2 tkato 2003-05-18 11:09:37 UTC
On Sun, 18 May 2003 01:30:05 -0700 (PDT)
dirk.meyer@dinoex.sub.org (Dirk Meyer) wrote:

>  any objections to commit this?

I suppose

>  +	${CP} ${WRKSRC}/README ${DOCSDIR}/README

had better be replaced with

	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2003-05-19 16:52:59 UTC
State Changed
From-To: open->closed

pacth to add docs has been committed. 


Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2003-05-19 16:52:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

I have looked inth this.