This PR supersedes #44407, please close #44407 in favor of this one. The last mail of Brian Somers, the current port maintainer, that I could dig up with groups.google.com, was from Oct 5. Effectively, the leafnode port has been unmaintained for Oct 23. I find that critical fixes should be responded to within ten working days if possible. I hope I'm not stepping on anyone's toes if I suggest that I take over the maintainership of this port. Being the upstream maintainer as well, this makes tracking new versions and bug fixes of leafnode easier. If Brian Somers is to return on short term, it'd be fine to make this commit as a non-maintainer-update and omit the MAINTAINER change of the patch below (YOU NEED TO EDIT THIS OUT MANUALLY IF YOU WANT TO OMIT IT!). This PR makes three ADDITIONAL changes over PR #44407. 1. change maintainer 2. add another critical bugfix in files/patch-aa 3. bump PORTREVISION. Please keep the PORTREVISION at 1 to hint that this port does not install vanilla 1.9.29. The patch will be part of leafnode 1.9.30 which will be released once one pending bug report has been resolved. #44407 already contained the update of leafnode from 1.9.27 to 1.9.29, which fixes a persistent SIGSEGV as upstream NNTP servers offer new newsgroups, fixes having multiple upstream servers with the same name but different port (for stunnel, for example). These changes are also part of this patch. Thanks a lot.
Responsible Changed From-To: freebsd-ports->brian Over to Maintainer
Return-Path: <brian@Awfulhak.org> X-Original-To: emma@localhost Delivered-To: emma@localhost.emma.line.org Received: from localhost (localhost [127.0.0.1]) by merlin.emma.line.org (Postfix) with ESMTP id 61615451E4 for <emma@localhost>; Mon, 11 Nov 2002 13:06:12 +0100 (CET) Received: from pop3.web.de by localhost with POP3 (fetchmail-6.1.2) for emma@localhost (single-drop); Mon, 11 Nov 2002 13:06:13 +0100 (CET) Received: from [217.204.245.18] (helo=Awfulhak.org) by mx09.web.de with esmtp (WEB.DE(Exim) 4.92 #42) id 18BCfd-0002iy-00 for matthias.andree@web.de; Mon, 11 Nov 2002 12:23:57 +0100 Received: from Awfulhak.org (www@localhost [127.0.0.1]) by Awfulhak.org (8.12.6/8.12.6) with SMTP id gABBNmH2008154; Mon, 11 Nov 2002 11:23:49 GMT (envelope-from brian@Awfulhak.org) Received: from 192.18.1.9 (SquirrelMail authenticated user brian) by mail.Awfulhak.org with HTTP; Mon, 11 Nov 2002 11:23:49 -0000 (GMT) Message-ID: <51367.192.18.1.9.1037013829.squirrel@mail.Awfulhak.org> Date: Mon, 11 Nov 2002 11:23:49 -0000 (GMT) Subject: Re: critical update port: news/leafnode, claim maintainership From: "Brian Somers" <brian@Awfulhak.org> To: <matthias.andree@web.de> In-Reply-To: <200211090047.gA90laNN005366@libertas.emma.line.org> References: <200211090047.gA90laNN005366@libertas.emma.line.org> X-Priority: 3 Importance: Normal Cc: <FreeBSD-gnats-submit@freebsd.org>, <brian@freebsd.org> X-Mailer: SquirrelMail (version 1.2.9) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit tests=IN_REP_TO,MAILTO_TO_SPAM_ADDR,QUOTED_EMAIL_TEXT,REFERENCES, SPAM_PHRASE_01_02,SUBJECT_IS_NEWS version=2.41 Sender: brian@Awfulhak.org X-Bogosity: No, tests=bogofilter, spamicity=0.374387, version=0.8.0.cvs.20021109 X-Spam-SpamProbe: X-Spam-Status: No, hits=-1.9 required=5.0 tests=IN_REP_TO,MAILTO_TO_SPAM_ADDR,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.50-cvs X-Spam-Level: Hi, Please go ahead and take over maintainership of leafnode. As you suggest, you're a more appropriate maintainer, and I have too little time these days to look after it properly. Thanks for your patience. -- Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org> <http://www.Awfulhak.org> <brian@[uk.]OpenBSD.org> Don't _EVER_ lose your sense of humour ! Matthias Andree said: > >>Submitter-Id: current-users >>Originator: Matthias Andree >>Organization: >>Confidential: no >>Synopsis: critical update port: news/leafnode, claim maintainership >> Severity: critical >>Priority: high >>Category: ports >>Class: change-request >>Release: FreeBSD 4.7-STABLE i386 >>Environment: > System: FreeBSD libertas.emma.line.org 4.7-STABLE FreeBSD 4.7-STABLE #3: > Sun Nov 3 18:49:35 CET 2002 > toor@libertas.emma.line.org:/usr/src/sys/compile/LIBERTAS i386 > > > >>Description: > This PR supersedes #44407, please close #44407 in favor of this one. > > The last mail of Brian Somers, the current port maintainer, that I could > dig up with groups.google.com, was from Oct 5. Effectively, the leafnode > port has been unmaintained for Oct 23. I find that critical fixes should > be responded to within ten working days if possible. > > I hope I'm not stepping on anyone's toes if I suggest that I take over > the maintainership of this port. Being the upstream maintainer as well, > this makes tracking new versions and bug fixes of leafnode easier. > > If Brian Somers is to return on short term, it'd be fine to make this > commit as a non-maintainer-update and omit the MAINTAINER change of the > patch below (YOU NEED TO EDIT THIS OUT MANUALLY IF YOU WANT TO OMIT > IT!). > > This PR makes three ADDITIONAL changes over PR #44407. > 1. change maintainer > 2. add another critical bugfix in files/patch-aa > 3. bump PORTREVISION. > > Please keep the PORTREVISION at 1 to hint that this port does not > install vanilla 1.9.29. The patch will be part of leafnode 1.9.30 which > will be released once one pending bug report has been resolved. > > #44407 already contained the update of leafnode from 1.9.27 to 1.9.29, > which fixes a persistent SIGSEGV as upstream NNTP servers offer new > newsgroups, fixes having multiple upstream servers with the same name > but different port (for stunnel, for example). These changes are also > part of this patch. > > Thanks a lot. > >>How-To-Repeat: > >>Fix: > > diff -Nur /usr/ports/news/leafnode/Makefile /root/leafnode/Makefile --- > /usr/ports/news/leafnode/Makefile Wed Sep 25 14:49:54 2002 > +++ /root/leafnode/Makefile Sat Nov 9 01:10:26 2002 > @@ -1,11 +1,13 @@ > # ports collection Makefile for: leafnode > # Whom: Brian Somers <brian@FreeBSD.org> > +# Date created: 1997-06-27 > # > # $FreeBSD: ports/news/leafnode/Makefile,v 1.25 2002/09/25 07:07:51 > brian Exp $ # > > PORTNAME= leafnode > -PORTVERSION= 1.9.27 > +PORTVERSION= 1.9.29 > +PORTREVISION= 1 > CATEGORIES= news > MASTER_SITES= http://dl.sourceforge.net/sourceforge/leafnode/ \ > http://www.dt.e-technik.uni-dortmund.de/~ma/${PORTNAME}/ \ > @@ -17,7 +19,7 @@ > ftp://ftp.gigabell.net/pub/leafnode/ > DISTNAME= ${PORTNAME}-${PORTVERSION}.rel > > -MAINTAINER= brian@FreeBSD.org > +MAINTAINER= matthias.andree@web.de > > LIB_DEPENDS= pcre.0:${PORTSDIR}/devel/pcre > > diff -Nur /usr/ports/news/leafnode/distinfo /root/leafnode/distinfo --- > /usr/ports/news/leafnode/distinfo Wed Sep 25 14:49:54 2002 > +++ /root/leafnode/distinfo Sat Nov 9 01:05:55 2002 > @@ -1 +1 @@ > -MD5 (leafnode-1.9.27.rel.tar.bz2) = e12e23d140ba84471c75b7d024fdd9ea > +MD5 (leafnode-1.9.29.rel.tar.bz2) = 75ac2cace12326c44613635ae6dd4b9d > diff -Nur /usr/ports/news/leafnode/files/patch-aa > /root/leafnode/files/patch-aa --- > /usr/ports/news/leafnode/files/patch-aa Thu Jan 1 01:00:00 1970 +++ > /root/leafnode/files/patch-aa Sat Nov 9 01:07:33 2002 > @@ -0,0 +1,22 @@ > +diff -u leafnode-1/CREDITS:1.7 leafnode-1/CREDITS:1.8 > +--- CREDITS:1.7 Tue Sep 24 18:24:13 2002 > ++++ CREDITS Wed Nov 6 02:44:42 2002 > +@@ -81,6 +81,7 @@ > + Heiko Nock <zifnab@wtal.de> > + Holger Graf <Holger.Graf@gmx.net> > + Holger Repp <retaliator@sbsd.de> > ++Jan Knutar <jknutar@nic.fi> > + Jarle Rongved <rongved@online.no> > + Jeff East <an972@freenet.carleton.ca> > + Jeff Grossman <jeff@stikman.com> > +diff -u leafnode-1/nntpd.c:1.81 leafnode-1/nntpd.c:1.83 > +--- nntpd.c:1.81 Tue Sep 24 18:04:01 2002 > ++++ nntpd.c Fri Nov 8 18:14:41 2002 > +@@ -521,6 +521,7 @@ > + markgroup = group->name; > + break; > + } > ++ p = q; > + } > + } > + /* if we don't have a localartno, then we need to mark this diff > -Nur /usr/ports/news/leafnode/pkg-plist /root/leafnode/pkg-plist --- > /usr/ports/news/leafnode/pkg-plist Wed Sep 25 14:49:54 2002 > +++ /root/leafnode/pkg-plist Sat Nov 9 01:05:55 2002 > @@ -1,3 +1,4 @@ > +bin/leafnode-version > bin/newsq > etc/leafnode/config.example > etc/leafnode/nntp.rules.dist >
State Changed From-To: open->closed Committed, thanks. I did reset PORTREVISION though. This tracks revisions of the port, not upstream changes. By your logic every port that includes a bug fix from the beginning should have a revision > 0 and this is clearly not the way we do things.