Bug 52790 - New port: shells/bash-completion
Summary: New port: shells/bash-completion
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-29 23:40 UTC by Kirk Strauser
Modified: 2003-09-29 13:44 UTC (History)
0 users

See Also:


Attachments
file.shar (3.79 KB, text/plain)
2003-05-29 23:40 UTC, Kirk Strauser
no flags Details
bash-completion.shar (3.78 KB, text/plain)
2003-06-04 15:36 UTC, Sergey Matveychuk
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Strauser 2003-05-29 23:40:13 UTC
The shells/bash-completion port installs Ian Macdonald's programmable
completion library for Bash 2.04 and above.  This gives users context-
sensitive tab-completion for such things as program arguments, SSH
hostnames, NFS mounts, and so on.
Comment 1 Will Andrews freebsd_committer freebsd_triage 2003-06-03 03:15:13 UTC
State Changed
From-To: open->feedback

Patch in the port doesn't apply. 
===>  Applying FreeBSD patches for bash-completion-20030527 
1 out of 1 hunks failed--saving rejects to bash_completion.rej 

Comment 2 Sergey Matveychuk 2003-06-04 15:36:19 UTC
I'v fixed patch-aa, added depends on shell/bash2, fixed pkg-message and 
tested.

----
Sem.
Comment 3 Kirk Strauser 2003-06-05 21:17:05 UTC
At 2003-06-04T14:36:19Z, Sergey Matveychuk <sem@ciam.ru> writes:

> I'v fixed patch-aa, added depends on shell/bash2, fixed pkg-message
> and tested.


Regarding the corrupted archive:

Thanks for fixing that.  It worked correctly on my system before using the
"shar" command to create the archive, but I don't know enough about that
command to get it to do the right thing.


Regarding the shells/bash2 dependency:

Should it be dependent on bash2?  While I agree that it's mostly useless
without bash2, isn't there a possibility that it could be regarded as
documentation, or used with a Linux bash from one of the linux_base
installations?


Regarding the pkg-message:

I tried to copy-and-paste from the pkg-message files from other ports that
were apparently done incorrectly.  Thanks for putting me on the right track.
-- 
Kirk Strauser
Comment 4 Sergey Matveychuk 2003-06-06 00:08:45 UTC
Kirk Strauser wrote:
> Thanks for fixing that.  It worked correctly on my system before using the
> "shar" command to create the archive, but I don't know enough about that
> command to get it to do the right thing.

I think the pacth was good and may be shar archive too. But something 
has changed tabs with white spaces. May be your MUA?

> Should it be dependent on bash2?  While I agree that it's mostly useless
> without bash2, isn't there a possibility that it could be regarded as
> documentation, or used with a Linux bash from one of the linux_base
> installations?

Yes, there is a possibility. But I don't think a man will use bash 
without putting path to it into $PATH.
If so port will satisfied. But if the port will not found bash in $PATH 
it'll install shell/bash2. I think it's reasonable.

---
Sem.
Comment 5 Kirk Strauser 2003-06-06 00:52:12 UTC
At 2003-06-05T23:08:45Z, Sergey Matveychuk <sem@ciam.ru> writes:

> I think the pacth was good and may be shar archive too. But something has
> changed tabs with white spaces. May be your MUA?


Actually, I used vim and send-pr to send the PR.  However, I *did* do some
copy-and-pasting in Konsole, and that might've been the problem.

> Yes, there is a possibility. But I don't think a man will use bash without
> putting path to it into $PATH.  If so port will satisfied. But if the port
> will not found bash in $PATH it'll install shell/bash2. I think it's
> reasonable.


OK, I agree that's reasonable.
-- 
Kirk Strauser
Comment 6 Tilman Keskinoz freebsd_committer freebsd_triage 2003-07-04 16:40:44 UTC
State Changed
From-To: feedback->open

Feedback was submitted.
Comment 7 Edwin Groothuis freebsd_committer freebsd_triage 2003-09-29 13:44:16 UTC
State Changed
From-To: open->closed

Commited, thanks!