While trying to build showimg 0.8.20030305 from the ports tree, make dies with: In file included from batchrenamer.h:23, from rename.h:28, from rename.cpp:20: /usr/include/utime.h:40: syntax error before `;' This seems to be due to utime.h not including time.h on 4-STABLE and can be worked around by exchanging the order of the two following lines in batchrenamer.h: #include <utime.h> #include <time.h> However, after this "fix", make chokes on the next problem: In file included from qtiffio.cpp:20: /usr/include/sys/mman.h:141: type specifier omitted for parameter With this one, I am not sure what the problem is. How-To-Repeat: Try to make graphics/showimg version 0.8.20030305 from ports on 4-STABLE.
I have fixed the problems with showimg on 4-STABLE by modifying two source files. However, I have never written a patch, so I hope somebody else could do it :(. What needs to be done is the following: In work/showimg-0.8-20030305/showimg/batchrenamer.h, the order of these two lines needs to be exchanged (this is required on FreeBSD according to the utime(3) man page): #include <utime.h> #include <time.h> In work/showimg-0.8-20030305/showimg/qtiffio.cpp, the following needs to be done: Before this line: #include <sys/mman.h> This must be added: #include <sys/types.h> Again, this is required on FreeBSD 4-STABLE according to the mmap(2) man page. It is not required on 5-CURRENT any more, I guess that is why it was never noticed when the port was commited (see also PR misc/21644). With these two changes, showimg compiles and runs on 4-STABLE. - Bartosz
State Changed From-To: open->closed Committed, thanks.