Bug 55396 - ports/sysutil/bsdsar (bad crontab)
Summary: ports/sysutil/bsdsar (bad crontab)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-08 20:20 UTC by David A. Koran
Modified: 2003-08-14 01:27 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David A. Koran 2003-08-08 20:20:00 UTC
 I nthe "rush" to update bsdsar, the developer mentioned "conf" file support for the applicatrion. In bsdsar's current state, the crontab entries it creates are bogus, or at the very least need editing. both need to have the "/var/log" part removed. ALso,  the file in the package (bsdsar.conf) needs to get copied to /usr/local/etc/ in the plist install script. otherwise, everything is broke. 
 
 Thanks...
Comment 1 Oliver Lehmann freebsd_committer freebsd_triage 2003-08-10 13:02:25 UTC
Responsible Changed
From-To: gnats-admin->freebsd-ports-bugs

Misfiled PR
Comment 2 Ceri Davies freebsd_committer freebsd_triage 2003-08-12 20:16:32 UTC
Adding to audit trail, from misfiled PR ports/55479:

Date: Mon, 11 Aug 2003 16:13:06 -0500
From: Eric Anderson <eric@trinitel.com>
Message-Id: <3F3806E2.8050608@trinitel.com>
References: <200308081851.h78IpNFd016142@mail.solo.net>

 David A. Koran wrote:
 
 >I nthe "rush" to update bsdsar, the developer mentioned "conf" file support for the applicatrion. In bsdsar's current state, the crontab entries it creates are bogus, or at the very least need editing. both need to have the "/var/log" part removed. ALso , the file in the package (bsdsar.conf) needs to get copied to /usr/local/etc/ in the plist install script. otherwise, everything is broke. 
 >
 
 This is a port problem, not a code problem, correct?
 
 Eric
Comment 3 Ceri Davies freebsd_committer freebsd_triage 2003-08-12 20:16:56 UTC
Adding to audit trail, from mifiled PR ports/55484:

Date: Tue, 12 Aug 2003 12:37:03 +0800
From: Yen-Ming Lee <leeym@FreeBSD.org>
Message-Id: <20030812043702.GA27401@utopia.leeym.com>
References: <200308081851.h78IpNFd016142@mail.solo.net> <3F3806E2.8050608@trinitel.com>

 On Mon, Aug 11, 2003 at 04:13:06PM -0500, Eric Anderson wrote:
 > David A. Koran wrote:
 > 
 > >I nthe "rush" to update bsdsar, the developer mentioned "conf" file 
 > >support for the applicatrion. In bsdsar's current state, the crontab 
 > >entries it creates are bogus, or at the very least need editing. both need 
 > >to have the "/var/log" part removed. ALso, the file in the package 
 > >(bsdsar.conf) needs to get copied to /usr/local/etc/ in the plist install 
 > >script. otherwise, everything is broke. 
 > 
 > This is a port problem, not a code problem, correct?
 > 
 > Eric
 
 Yes, it's a port problem.
 
 I have no idea how will the maintainer handle the crontab.
 However, the patch about the bsdsar.conf is attached.
 
 regards,
 -- 
 Yen-Ming Lee [§õ«Û©ú] KeyID: 0x5EB52E51 : www.leeym.com : Taipei, Taiwan
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/sysutils/bsdsar/Makefile,v
 retrieving revision 1.4
 diff -u -r1.4 Makefile
 --- Makefile	6 Aug 2003 10:16:51 -0000	1.4
 +++ Makefile	12 Aug 2003 04:31:14 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	bsdsar
  PORTVERSION=	1.10
 +PORTREVISION=	1
  CATEGORIES=	sysutils
  MASTER_SITES=	http://www.googlebit.com/bsdsar/
  
 @@ -19,6 +20,10 @@
  .for file in bsdsar bsdsar_gather
  	${INSTALL_SCRIPT} ${WRKSRC}/${file} ${PREFIX}/bin
  .endfor
 +	${INSTALL_DATA} ${WRKSRC}/bsdsar.conf ${PREFIX}/etc/bsdsar.conf.sample
 +.if !exists(${PREFIX}/etc/bsdsar.conf)
 +	${CP} ${PREFIX}/etc/bsdsar.conf.sample ${PREFIX}/etc/bsdsar.conf
 +.endif
  	${SETENV} PKG_PREFIX="${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
  .if !defined(NOPORTDOCS)
  	${MKDIR} ${DOCSDIR}
 Index: pkg-plist
 ===================================================================
 RCS file: /home/pcvs/ports/sysutils/bsdsar/pkg-plist,v
 retrieving revision 1.2
 diff -u -r1.2 pkg-plist
 --- pkg-plist	14 Sep 2002 22:32:03 -0000	1.2
 +++ pkg-plist	12 Aug 2003 04:31:14 -0000
 @@ -1,5 +1,7 @@
  bin/bsdsar
  bin/bsdsar_gather
 -%%PORTDOCS%%share/doc/bsdsar/CHANGELOG
 -%%PORTDOCS%%share/doc/bsdsar/README
 -%%PORTDOCS%%@dirrm share/doc/bsdsar
 +@unexec if cmp -s %D/etc/bsdsar.conf %D/etc/bsdsar.conf.sample; then rm -f %D/etc/bsdsar.conf; fi
 +etc/bsdsar.conf.sample
 +%%PORTDOCS%%%%DOCSDIR%%/CHANGELOG
 +%%PORTDOCS%%%%DOCSDIR%%/README
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%
Comment 4 Yen-Ming Lee freebsd_committer freebsd_triage 2003-08-14 01:27:41 UTC
State Changed
From-To: open->closed

Committed, thanks.