Bug 55940 - isakmpd pcap support is broken
Summary: isakmpd pcap support is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-25 00:20 UTC by jflemer
Modified: 2003-08-25 10:30 UTC (History)
0 users

See Also:

Attachments
file.diff (644 bytes, patch)
2003-08-25 00:20 UTC, jflemer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jflemer 2003-08-25 00:20:13 UTC 
	The isakmpd port comes with a pcap.h that is not compatible with
	the FreeBSD pcap.h.  As a result, the pcap file written by isakmpd
	has an incorrect 'linktype' in the header.  Thus, if one tries to
	use the pcap file with a FreeBSD tool like tcpdump, the packets are
	incorrectly (read: not at all) decoded.

Fix: Isakmpd should be compiled with -DHAVE_PCAP so that the FreeBSD
	system pcap.h is used, not the included pcap.h.  The existing
	files/patch-Makefile.sysdep should be replaced with the one
	below.  When compiled with HAVE_PCAP, isakmpd uses the correct
	value of DLT_LOOP (108) for the pcap header, not the wrong one
	(12), and tcpdump and ethereal both correctly read the file.

	This patch was tested only on -current, tho I believe that libpcap
	has been in FreeBSD for a very long time...

--- files/patch-Makefile.sysdep begins here ---
$FreeBSD$
How-To-Repeat: 	Run isakmpd with -L to produce /var/run/isakmpd.pcap, then:
$ tcpdump -nvr /var/run/isakmpd.pcap 
18:34:05.281823 unknown ip 0
18:34:05.288267 unknown ip 0
18:34:05.395181 unknown ip 0
...
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2003-08-25 10:30:02 UTC 
State Changed
From-To: open->closed

Commited, thanks!