- Fix bento build error (mark IGNORE for perl < 5.6) - Make portlint happy Generated with FreeBSD Port Tools 0.26
Hello Lars, I have a similar patch for this problem, which also passed portlint check and do the right thing on the fly. How about this one? I'll create a slave port for XML::SimpleObject::LibXML separately: ========================================================== diff -ruN /usr/ports/textproc/p5-XML-SimpleObject/Makefile ./Makefile --- /usr/ports/textproc/p5-XML-SimpleObject/Makefile Mon Aug 25 17:34:15 2003 +++ ./Makefile Tue Sep 2 16:57:17 2003 @@ -7,19 +7,21 @@ PORTNAME= XML-SimpleObject PORTVERSION= 0.53 +PORTREVISION= 1 CATEGORIES= textproc perl5 MASTER_SITES= ${MASTER_SITE_PERL_CPAN} MASTER_SITE_SUBDIR= XML PKGNAMEPREFIX= p5- -WRKSRC?= ${WRKDIR}/${PORTNAME}${PORTVERSION} - MAINTAINER= ports@FreeBSD.org COMMENT= API for accessing the structure of an XML document -BUILD_DEPENDS= ${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser +BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser + +WRKSRC?= ${WRKDIR}/${PORTNAME}${PORTVERSION} PERL_CONFIGURE= YES +CONFIGURE_ARGS+= DIR='Enhanced' MAN3= XML::SimpleObject.3 MANPREFIX= ${PREFIX}/lib/perl5/${PERL_VERSION} ========================================================== foxfair
>I have a similar patch for this problem, which also passed portlint >check and do the right thing on the fly. How about this one? I agree - much neater. But if you add "CONFIGURE_ARGS+= DIR='Enhanced'", won't you have to fix the pkg-plist as well? >I'll create a slave port for XML::SimpleObject::LibXML separately: I noticed that the author has made a separate module for XML::SimpleObject::LibXML. Maybe you should port that, instead of making it a slave of this port. By the way, is the PORTREVISION bump really needed? Exisisting installations will work anyway, won't they? Or is this to force bento to upgrade? /Lars
Foxfair Hu <foxfair@drago.fomokka.net> wrote: > Actually XML::SimpleObject::LibXML is included in XML::SimpleObject. > And they use the same package file in CPAN. You can see a LibXML/ sub > directory after you extract it. I'm not sure I understand what you mean about "the same package file in CPAN". In CPAN, the $VERSIONs of LibXML.pm are not the same: DBRIAN/XML-SimpleObject-0.53/LibXML/LibXML.pm 0.53 DBRIAN/XML-SimpleObject-LibXML-0.59/LibXML.pm 0.59 The diff between those two versions seems to be non-trivial - if you want to provide XML::SimpleObject::LibXML, I suggest you do that by porting XML-SimpleObject-LibXML-0.59 rather that taking the LibXML.pm from XML-SimpleObject-0.53. It seems the original author has created a bit of a version mess here, but there is no need for us porters to continue that tradition :) > Since there will be a pkg-plist change too, so bump PORTREVISION > is also needed. Fine by me! Commit at will :) /Lars
State Changed From-To: open->closed Committed a similar fix, thanks!