Update security/clamav-devel - use included libtool (seems heavily patched) - make packageable and include a working configure file - don't install useless .la files - use DATADIR - 510001 is FreeBSD 5.10, 5.1-CURRENT is 501100 - Change log and pid file location to more universal one - RC-ng scripts for clamd and clamav-milter are planned - Thanks to Oliver Eikemeier from whom I stole most (clamav-port) Fix: Create a file files/patch-ltmain.sh and then apply this diff
Responsible Changed From-To: freebsd-ports-bugs->dinoex I will take care of it.
Hi Rob, > - Thanks to Oliver Eikemeier from whom I stole most (clamav-port) Nice that you like my patch... > +.ifdef USE_LIBTOOL_VER > + @${REINPLACE_CMD} -e '/^LIBTOOL=/s|\$$(top_builddir)/libtool|${LIBTOOL}|' \ > + ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} > +.endif This only makes sense with the comment `#USE_LIBTOOL_VER=14' above. It basically says: - normally you don't need files/patch-ltmain.sh, it's supposed to be USE_LIBTOOL_VER=14 @${REINPLACE_CMD} -e '/^LIBTOOL=/s|\$$(top_builddir)/libtool|${LIBTOOL}|' \ ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} - but this didn't work and I was to lazy to fix it, so I just patched ltmain.sh - the commented USE_LIBTOOL_VER=14 (and ifdef'd REINPLACE_CMD) is an incitement for someone to find out what went wrong and fix it. probably you should just omit these lines, they look strange without the #USE_LIBTOOL_VER=14 (or fix it and omit files/patch-ltmain.sh ;-)... > +++ clamav-devel/pkg-plist Mon Sep 29 18:27:22 2003 > [...] > @unexec echo "" > @unexec echo "=========================================================" > @unexec echo " If you want to deinstall this package permanently then" I won't expect this in an pkg-plist, a `packing list' is supposed to be concerned with the package files, not messages. Just a style question, but I think you should use a pkg-deinstall (POST-DEINSTALL) script here.
State Changed From-To: open->closed committed, thanks.
Oliver Eikemeier wrote: > Hi Rob, > >> - Thanks to Oliver Eikemeier from whom I stole most (clamav-port) > > Nice that you like my patch... > >> +.ifdef USE_LIBTOOL_VER >> + @${REINPLACE_CMD} -e >> '/^LIBTOOL=/s|\$$(top_builddir)/libtool|${LIBTOOL}|' \ >> + ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} >> +.endif > > > This only makes sense with the comment `#USE_LIBTOOL_VER=14' above. It > basically says: > > - normally you don't need files/patch-ltmain.sh, it's supposed to be > USE_LIBTOOL_VER=14 > @${REINPLACE_CMD} -e > '/^LIBTOOL=/s|\$$(top_builddir)/libtool|${LIBTOOL}|' \ > ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} > > - but this didn't work and I was to lazy to fix it, so I just patched > ltmain.sh > > - the commented USE_LIBTOOL_VER=14 (and ifdef'd REINPLACE_CMD) is an > incitement > for someone to find out what went wrong and fix it. > > probably you should just omit these lines, they look strange without the > #USE_LIBTOOL_VER=14 > (or fix it and omit files/patch-ltmain.sh ;-)... > >> +++ clamav-devel/pkg-plist Mon Sep 29 18:27:22 2003 >> [...] >> @unexec echo "" >> @unexec echo "=========================================================" >> @unexec echo " If you want to deinstall this package permanently then" > > > I won't expect this in an pkg-plist, a `packing list' is supposed to be > concerned with the package files, not messages. Just a style question, > but I think you should use a pkg-deinstall (POST-DEINSTALL) script here. > Hi Oliver, I'm contacting you through this list because your server doesn't allow my IP ;-((. Maybe it's a good idea to get this patch in the clamav tree ? I'd be happy to send in the patch. Rob Evers