Bug 57823 - PATCH: obey portlint warnings
Summary: PATCH: obey portlint warnings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: kbyanc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-10 02:00 UTC by jj
Modified: 2004-01-03 21:31 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jj 2003-10-10 02:00:39 UTC 
Portlint complained about a couple things, and I simply obeyed what it 
suggested.

Fix: 

diff ./Makefile /usr/ports/net/p5-Net-Radius/Makefile
10d9
< PORTREVISION=	1
18c18
< BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
---
> BUILD_DEPENDS=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
26c26
< 	${FIND} ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
---
> 	find ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
How-To-Repeat: Run portlint on the port.
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2003-10-10 02:12:53 UTC 
>> (10.09.2003 @ 2055 PST): Shannon -jj Behrens said, in 1.5K: <<
> diff ./Makefile /usr/ports/net/p5-Net-Radius/Makefile
> 10d9
> < PORTREVISION=	1
> 18c18
> < BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
> ---
> > BUILD_DEPENDS=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
> 26c26
> < 	${FIND} ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
> ---
> > 	find ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
>> end of "ports/57823: PATCH: obey portlint warnings" from Shannon -jj Behrens <<

I think you ran diff with the arguments reversed. At least, I hope so.

Bumping PORTREVISION is unnecessary here, and the find line should be:
${FIND} ${WRKSRC} -type f | ${XARGS} ${PERL5} -pe -e "s:\r::g"

# Adam


--
Adam Weinberger
vectors.cx	>>  adam@vectors.cx	>>  http://www.vectors.cx
magnesium.net	<<  adamw@magnesium.net	<<  http://www.magnesium.net/~adamw
FreeBSD		>>  adamw@FreeBSD.org	>>  http://people.freebsd.org/~adamw
#vim:set ts=8: 8-char tabs prevent tooth decay.
Comment 2 jj 2003-10-10 02:21:51 UTC 
On Thu, Oct 09, 2003 at 09:12:53PM -0400, Adam Weinberger wrote:
> >> (10.09.2003 @ 2055 PST): Shannon -jj Behrens said, in 1.5K: <<
> > diff ./Makefile /usr/ports/net/p5-Net-Radius/Makefile
> > 10d9
> > < PORTREVISION=	1
> > 18c18
> > < BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
> > ---
> > > BUILD_DEPENDS=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
> > 26c26
> > < 	${FIND} ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
> > ---
> > > 	find ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
> >> end of "ports/57823: PATCH: obey portlint warnings" from Shannon -jj Behrens <<
> 
> I think you ran diff with the arguments reversed. At least, I hope so.

You're right.

> Bumping PORTREVISION is unnecessary here, and the find line should be:
> ${FIND} ${WRKSRC} -type f | ${XARGS} ${PERL5} -pe -e "s:\r::g"

Excellent.  It's obvious that you're paying attention, whereas I was
just blindly following portlint.

Thanks,
-jj

-- 
Research is the best place to be:  you work your buns off, and if it
works you're a hero; if it doesn't, well--nobody else has done it yet
either, so you're still a valiant nerd.
Comment 3 Kirill Ponomarev freebsd_committer freebsd_triage 2003-10-10 07:18:28 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->kbyanc

Over to maintainer
Comment 4 kbyanc freebsd_committer freebsd_triage 2004-01-03 21:30:51 UTC 
State Changed
From-To: open->closed

Committed.  Thanks!