Bug 58885 - [PATCH] bsd.port.mk: include dynamically generated scripts/message into packages
Summary: [PATCH] bsd.port.mk: include dynamically generated scripts/message into packages
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-03 16:40 UTC by Oliver Eikemeier
Modified: 2013-03-17 02:07 UTC (History)
0 users

See Also:

Attachments
bsd.port.mk.patch (1.12 KB, patch)
2003-11-03 16:40 UTC, Oliver Eikemeier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Eikemeier 2003-11-03 16:40:19 UTC 
If a port creates pkg-install, pkg-deinstall, pkg-req or pkg-message dynamically, i.e.:

  PKGMESSAGE=${WRKDIR}/pkg-message
  	${SED} -e "s,%%PREFIX%%,${PREFIX},g" ${PKGDIR}/pkg-message >${PKGMESSAGE}

`make package' does not include these files, because bsd.port.mk tests for their
existence before the build step is performed.

Fix: A workaround is to use

  make install; make package

because for the second call the dynamically generated files exist.

Bento does not do this. The following patch is ugly, but may help:
How-To-Repeat: 
cd /usr/ports/security/cyrus-sasl2; make package
pkg_info -i 'cyrus-sasl-2*'
pkg_info -i /usr/ports/packages/All/cyrus-sasl-2.*
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2003-11-03 19:18:54 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

portmgr territory
Comment 2 Oliver Eikemeier 2003-11-04 16:34:21 UTC 
May fix PR 57870
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 5 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 6 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 7 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 8 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Fixed with the comment made in the follow-up.  Thanks for reporting.
Comment 9 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 10 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 11 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 12 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed with the additional check of INSTALL_AS_USER.  Thanks!
Comment 13 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 14 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 15 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 16 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 17 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 18 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 19 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Final version committed, thanks!
Comment 20 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 21 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 22 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 23 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 24 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: open->closed

The patch we discussed was committed.