Introducing a new Makefile knob: WITH_ENCODING_PATCH Allows for automatic Russian encoding detection in ID3 tags, filenames, etc The knob will be used by russian/xmms port which comes in the next PR.
I am not able to fetch the patchfile. I would also strongly suggest using PATCHFILES and PATCH_SITES for this kind of stuff. As for checking whether the patch itself is sane, I don't think I am the right person for checking this. eSk
On Mon, Nov 17, 2003 at 03:19:29PM +0100, Oliver Eikemeier wrote: > > I am not able to fetch the patchfile. I would also strongly suggest > > using PATCHFILES and PATCH_SITES for this kind of stuff. As for No way. Here's a quote from porter's handbook: "If the patch is distributed with some other files, such as documentation, in a gzip'd tarball, you cannot just use PATCHFILES. If that is the case, add the name and the location of the patch tarball to DISTFILES and MASTER_SITES." That's exactly the reason for me using MASTER_SITES. > > checking whether the patch itself is sane, I don't think I am the > > right person for checking this. > Seems to be an reasonable alternative. Close? As for unfetchable distfile, the last update in bsd.port.mk seems to have broken the grouping feature. Attached is a new version of patch. -- be9
State Changed From-To: open->feedback Maintainer advised
Dear maintainer, could you approve or disaprove PR 59076 <http://www.freebsd.org/cgi/query-pr.cgi?pr=59076> Thanks, -- Mathieu Arnold
Here's a less intrusive version of the patch. Note that doing "subdir:group" for MASTER_SITE_SUBDIR does for some reason not work. A little workaround (hack) is therefore required.
On Wed, Nov 26, 2003 at 07:43:20PM +0100, Espen Skoglund wrote: Content-Description: message body text > Here's a less intrusive version of the patch. Note that doing > "subdir:group" for MASTER_SITE_SUBDIR does for some reason not work. > A little workaround (hack) is therefore required. Ah, that's ok. I used :dist due to the same reason of something having been broken. More intrusive, less hack. You preferred less intrusive, more hack, that's it. :-) -- be9
State Changed From-To: feedback->open Feedback received.
State Changed From-To: open->analyzed I'll commit this after the freeze.
Responsible Changed From-To: freebsd-ports-bugs->pav I'll commit this after the freeze.
State Changed From-To: analyzed->closed Committed, thanks!