Bug 59151 - [Port Fix] security/gnupg doesn't use USE_OPENLDAP correctly
Summary: [Port Fix] security/gnupg doesn't use USE_OPENLDAP correctly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-10 23:10 UTC by Alex Dupre
Modified: 2003-11-12 13:32 UTC (History)
1 user (show)

See Also:

Attachments
gnupg.diff (489 bytes, patch)
2003-11-10 23:10 UTC, Alex Dupre 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Dupre 2003-11-10 23:10:12 UTC 
USE_OPENLDAP and WITH_LDAP are inverted.
Fix them and remove the second useless 'if'.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2003-11-10 23:58:27 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->kuriyama

Over to maintainer.
Comment 2 Mark Linimon 2003-11-11 07:23:39 UTC 
Adding to audit trail from misfiled PR ports/59161 by kuriyama-san:

  It looks your patch simplify better.  But I cannot understand what is
  inverted around here...
Comment 3 Mark Linimon 2003-11-11 07:26:43 UTC 
And from yet another marooned followup by sysadmin@alexdupre.com:

  A user shouldn't define USE_OPENLDAP. If he wants ldap support and
  hasn't openldap-client he should define WITH_LDAP, otherwise the
  openldap dependency cannot be built, since in the openldap Makefile
  there is:

  .if defined(USE_OPENLDAP)
  .error You have `USE_OPENLDAP' defined either in your environment or 
in make(1)
  arguments.
  .endif
Comment 4 Jun Kuriyama freebsd_committer freebsd_triage 2003-11-12 13:32:20 UTC 
State Changed
From-To: open->closed

Ah, understood.  Thanks, committed!