Bug 59319 - Update port: games/foobillard 2.6 -> 2.9
Summary: Update port: games/foobillard 2.6 -> 2.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-16 06:50 UTC by Jeremy Messenger
Modified: 2003-11-16 18:57 UTC (History)
1 user (show)

See Also:

Attachments
foobillard.diff (6.48 KB, patch)
2003-11-16 06:50 UTC, Jeremy Messenger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Messenger 2003-11-16 06:50:20 UTC 
- Update to 2.9.
- Add an new option/define, WITH_SDL.

Fix: Here what I have made some change:

	- Update to 2.9.
	- Remove SDL from LIB_DEPENDS and use USE_SDL. Also, remove the
	  SDL_CONFIG since the USE_SDL will take care of it.
	- Add FREETYPE_CONFIG.
	- Remove MAKE_ENV, since foobillard's src/Makefile should take care.
	- Add a new define/option, WITH_SDL.
	- Remove MANCOMPRESSED=no, user will decide if they don't want the
	  compress the manpage and can be done by via the /etc/make.conf.
	- Add pre-everything to explain that it has two defines/options.

I think, it's all. I personal would change the prefix from LOCALBASE to X11BASE,
but it doesn't matter to me. It's up to you, so I am leaving the prefix alone.

Please do feel free if you dislike my change and modify it. :-)
How-To-Repeat: n/a
Comment 1 Jeremy Messenger 2003-11-16 06:56:37 UTC 
To clear a little bit..

> prefix from LOCALBASE to X11BASE

I mean, USE_X_PREFIX, of course.

> Please do feel free if you dislike my change and modify it.

Not sure if the grammar is correct. I mean, if you dislike then please do 
feel free to modify it.

Cheers,
Mezz


-- 
bsdforums.org 's moderator, mezz.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2003-11-16 14:32:09 UTC 
Dear maintainer, please take a look at

http://www.freebsd.org/cgi/query-pr.cgi?pr=59319

Do you approve this update?

-- 
Pav Lucistnik <pav@FreeBSD.org>
              <pav@oook.cz>
Comment 3 thomas 2003-11-16 16:28:59 UTC 
Hi

Looks ok for me. Feel free to commit it :)

regards
Thomas Vogt

Pav Lucistnik wrote:

>Dear maintainer, please take a look at
>
>http://www.freebsd.org/cgi/query-pr.cgi?pr=59319
>
>Do you approve this update?
>
>  
>
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2003-11-16 16:34:32 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

I'll take this one.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2003-11-16 18:57:27 UTC 
State Changed
From-To: open->closed

Committed with some modifications. Thanks!