Bug 59990 - [PATCH] net/samba: register popt dependency
Summary: [PATCH] net/samba: register popt dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: dwcjr
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-06 15:40 UTC by Matthias Andree
Modified: 2003-12-22 01:55 UTC (History)
1 user (show)

See Also:


Attachments
samba-2.2.8a.patch (405 bytes, patch)
2003-12-06 15:40 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree 2003-12-06 15:40:02 UTC
This patch adds a LIB_DEPENDS line for popt.

Please add this patch to the 5.2 ports and move the tag. re@ and
portmgr@ are Cc'd -- please approve or reject.

REASONS:

1. Samba's ./configure will automatically pull in the system popt
   if popt is installed when Samba (as port) is compiled, without
   registering it as a dependency. This means popt can later be removed
   without complaint, but this may break Samba. (Has been observed live
   on my system).
   
2. If Samba uses popt, we should use a system-wide shared object rather
   than letting Samba link against a local popt copy locally, to
   decrease the number of recompiles should there be a cricital popt bug
   discovered in the future. I am not aware of any such current issue,
   this is to increase maintainability.

Port maintainer (dwcjr@FreeBSD.org) is also cc'd.

Generated with FreeBSD Port Tools 0.50
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2003-12-07 17:50:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dwcjr

Over to maintainer.
Comment 2 dwcjr 2003-12-07 18:06:06 UTC
I've been bugging the samba developers about how configure autodetects
things and them not providing a way to disable that detection.  This looks
good until I can get them to provide a new flag in 3.0.x to disable
configure from detecting popt
Comment 3 Pete Fritchman freebsd_committer freebsd_triage 2003-12-22 01:55:57 UTC
State Changed
From-To: open->closed

Committed, thanks.