Bug 63505 - [Patch] multimedia/libfame -- SSE support does not work right
Summary: [Patch] multimedia/libfame -- SSE support does not work right
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-28 17:40 UTC by Michael Johnson
Modified: 2004-02-28 18:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Johnson 2004-02-28 17:40:11 UTC 
The way SSE is enabled right now is backwards, if you define WITH_SSE it disables it and if you don't define WITH_SSE it is enabled.

I am submitting 2 patches to fix this. If we want SSE enabled default use patch1, if we want SSE to be enabled when defined use patch2.

Orignally in http://www.freebsd.org/cgi/query-pr.cgi?pr=63417 I choose to use patch2 because mplayer enables SSE default. 

Patch1  
  o Works the opposite of myplayer and disables it default and adds WITH_SSE
Patch2
   o Works the same way mplayer does, enables it default and adds WITHOUT_SSE

How-To-Repeat: === Begin Patch1 === 
diff -ruN multimedia/libfame.orig/Makefile multimedia/libfame/Makefile
--- multimedia/libfame.orig/Makefile	Sat Feb 28 12:15:17 2004
+++ multimedia/libfame/Makefile	Sat Feb 28 12:25:50 2004
@@ -18,7 +18,7 @@
 USE_LIBTOOL=	yes
 INSTALLS_SHLIB=	yes
 
-.if !defined(WITH_SSE)
+.if defined(WITH_SSE)
 CONFIGURE_ARGS+=	--enable-sse
 .endif
 
@@ -33,7 +33,7 @@
 	fame_start_frame.3 fame_end_frame.3
 
 pre-everything::
-.if !defined(WITHOUT_SSE)
+.if !defined(WITH_SSE)
 	@${ECHO_MSG} " You can enable SSE optimized routines by defining WITH_SSE."
 	@${ECHO_MSG} ""
 .endif
=== End Patch1 ===

=== Begin Patch2 ===
diff -ruN multimedia/libfame.orig/Makefile multimedia/libfame/Makefile
--- multimedia/libfame.orig/Makefile	Sat Feb 28 12:15:17 2004
+++ multimedia/libfame/Makefile	Sat Feb 28 12:30:06 2004
@@ -18,7 +18,7 @@
 USE_LIBTOOL=	yes
 INSTALLS_SHLIB=	yes
 
-.if !defined(WITH_SSE)
+.if !defined(WITHOUT_SSE)
 CONFIGURE_ARGS+=	--enable-sse
 .endif
 
@@ -34,7 +34,7 @@
 
 pre-everything::
 .if !defined(WITHOUT_SSE)
-	@${ECHO_MSG} " You can enable SSE optimized routines by defining WITH_SSE."
+	@${ECHO_MSG} " You can disable SSE optimized routines by defining WITHOUT_SSE."
 	@${ECHO_MSG} ""
 .endif
=== End Patch2 ===
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-02-28 17:53:33 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

Take, this fixes what I messed earlier today
Comment 2 Michael Johnson 2004-02-28 17:55:48 UTC 
I made a typo in Patch2 please use this if we choose to use WITHOUT_SSE 
and have it enabled default

diff -ruN multimedia/libfame.orig/Makefile multimedia/libfame/Makefile
--- multimedia/libfame.orig/Makefile	Sat Feb 28 12:15:17 2004
+++ multimedia/libfame/Makefile	Sat Feb 28 12:53:39 2004
@@ -18,7 +18,7 @@
  USE_LIBTOOL=	yes
  INSTALLS_SHLIB=	yes

-.if !defined(WITH_SSE)
+.if !defined(WITHOUT_SSE)
  CONFIGURE_ARGS+=	--enable-sse
  .endif

@@ -34,7 +34,7 @@

  pre-everything::
  .if !defined(WITHOUT_SSE)
-	@${ECHO_MSG} " You can enable SSE optimized routines by defining 
WITH_SSE."
+	@${ECHO_MSG} " You can disable SSE optimized routines by defining 
WITHOUT_SSE."
  	@${ECHO_MSG} ""
  .endif
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-02-28 17:56:48 UTC 
State Changed
From-To: open->closed

Committed. I went with patch1, as it respects defaults 
set by software authors (mmx on, sse off).