Bug 64027 - [Maintainer] lang/pnet* -- add PORTDOCS and missing lib for X support.
Summary: [Maintainer] lang/pnet* -- add PORTDOCS and missing lib for X support.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-10 04:00 UTC by Michael Johnson
Modified: 2004-03-10 23:56 UTC (History)
0 users

See Also:

Attachments
file.diff (928 bytes, patch)
2004-03-10 04:00 UTC, Michael Johnson 		no flags Details | Diff
file.diff (1.48 KB, patch)
2004-03-10 04:00 UTC, Michael Johnson 		no flags Details | Diff
file.diff (1.08 KB, patch)
2004-03-10 04:00 UTC, Michael Johnson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Johnson 2004-03-10 04:00:35 UTC 
add RUN_DEPENDS= libXext so we can use gui programs

add PORTDOCS to pnet-base & pnetlib

I chose RUN_DEPENDS instead of LIB_DEPENDS for libXext because it does not need it to build.

I did not bump the PORTREVISION on ml-pnet & pnetc because they are unaffected.

please close and do not comment pr-63969
Comment 1 Michael Johnson 2004-03-10 04:09:45 UTC 
actually, I don't know what I was thinking about BUILD_DEPENDS vs. 
LIB_DEPENDS
in lang/pnet/Makefile for pnet uses X* libs and headers to compile

please change the following from my patch in lang/pnet/Makefile

.if !defined(NO_X)
-RUN_DEPENDS+=   ${X11BASE}/lib/libXext.so.6:${PORTSDIR}/x11/libXext
+LIB_DEPENDS+=   Xext.6:${PORTSDIR}/x11/libXext
.endif

and add the following to lang/pnet-base/Makefile

.if !defined(NO_X)
LIB_DEPENDS+=   Xext.6:${PORTSDIR}/x11/libXext
.endif
Comment 2 Oliver Eikemeier 2004-03-10 09:39:54 UTC 
michael johnson wrote:

> +.ifndef(PORTDOCS)
> +.for plistfile in ${DOC_FILES}
> +PLIST_FILES+=	share/doc/${PORTNAME}/${plistfile}
> +.endfor
> +PLIST_DIRS+=	share/doc/${PORTNAME}
> +.endif
> +

You could write
  PORTDOCS=	${DOC_FILES}
instead
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-03-10 22:16:35 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

I'm working on this with submitter
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-03-10 23:55:59 UTC 
State Changed
From-To: open->closed

Committed, thanks!