The configure script of CTorrent 1.3.2 checks for SHA1_Init(3) in libssl, libcrypt and libmd (in that order) but then checks for the presence of <openssl/sha.h> regardless if SHA1_Init(3) was found in libssl or one of the other libraries. Moreover, the CTorrent sources only use <openssl/sha.h> instead of <sha.h> for libcrypt/libmd. These causes two problems: - On FreeBSD, libssl doesn't contain SHA1_Init(3) (it's in libmd), from configure, run on FreeBSD 5.2-current _with_ OpenSSL in the base: checking for SHA1_Init in -lssl... no checking for SHA1_Init in -lcrypt... no checking for SHA1_Init in -lmd... yes <...> checking openssl/sha.h usability... yes checking openssl/sha.h presence... yes checking for openssl/sha.h... yes The consecence here is that <openssl/sha.h> is used instead of the correct <sha.h>, however this is rather harmless. - On a FreeBSD _without_ OpenSSL in the base (port version of OpenSSL doesn't work either), CTorrent doesn't build because it can't find <openssl/sha.h>, without really needing it: checking for SHA1_Init in -lssl... no checking for SHA1_Init in -lcrypt... no checking for SHA1_Init in -lmd... yes <...> checking openssl/sha.h usability... no checking openssl/sha.h presence... no checking for openssl/sha.h... no configure: error: Error, OpenSSL header file sha.h not found. The patch below fixes this, a proper version for configure.in was sent to the author. Other changes are to add SIZE info and quiet this one: configure: WARNING: you should use --build, --host, --target How-To-Repeat: Try to build CTorrent 1.3.2 on a FreeBSD without OpenSSL in the base.
Responsible Changed From-To: freebsd-ports-bugs->netchild I take care of it.
Adding to audit trail, from misfiled PR ports/65311: From: Florent Thoumie <flz@xbsd.org> Message-Id: <4074F59C.8090605@xbsd.org> Date: Thu, 08 Apr 2004 08:47:56 +0200 In-Reply-To: <200403172216.i2HMGoo4032080@alchemy.franken.de> I just received a mail from CTorrent developer. He's busy for now, so he won't release a new version for weeks. Actually he didn't received any mail concerning this issue, I told him to have a look at this PR, so chances are he will include these changes in the next release (1.5 in debug).
Adding to audit trail, from misfiled PR ports/65334: From: Marius Strobl <marius@alchemy.franken.de> Message-Id: <20040408201540.A94005@newtrinity.zeist.de> Date: Thu, 8 Apr 2004 20:15:40 +0200 References: <200403172216.i2HMGoo4032080@alchemy.franken.de> <4074F59C.8090605@xbsd.org> On Thu, Apr 08, 2004 at 08:47:56AM +0200, Florent Thoumie wrote: > I just received a mail from CTorrent developer. > > He's busy for now, so he won't release a new version for weeks. > > Actually he didn't received any mail concerning this issue, I told him > to have a look at this PR, so chances are he will include these changes > in the next release (1.5 in debug). Hrm, strange, I used bsdi@sina.com, do you have another email-address of him? FYI, the patch for the configure script in the PR is a bit hackish; doing it in a clean way that is appropriate for the vendor branch would either mean a much bigger patch for configure in the port or depending on autoconf to build the port. I didn't see a need to do it that way as the result for the port is the same (but hence I tried to send a better version to the author). Thanks for looking into this!
Marius Strobl wrote: > Hrm, strange, I used bsdi@sina.com, do you have another email-address > of him? Nope, i used bsdi@sina.com. > FYI, the patch for the configure script in the PR is a bit hackish; > doing it in a clean way that is appropriate for the vendor branch > would either mean a much bigger patch for configure in the port or > depending on autoconf to build the port. I didn't see a need to do > it that way as the result for the port is the same (but hence I tried > to send a better version to the author). I do think this is the right thing to do. > Thanks for looking into this! My pleasure.
Adding to audit trail - this followup was submitted to the wrong PR: From: Florent Thoumie <flz@xbsd.org> To: freebsd-gnats-submit@FreeBSD.org Cc: Marius Strobl <marius@alchemy.franken.de> Subject: Re: ports/65311: Re: net/ctorrent: CTorrent 1.3.2 bogusly depends on OpenSSH header Date: Sat, 15 May 2004 04:33:49 +0200 Should we keep this PR open ? The main developer has been contacted and Marius concluded he'll try to send a less "hackish" version of the patch directly to the author. I have no news from him, so if Marcus has a clean patch to add, this could be a good idea to commit it. No changes has been made in the CVS Repository for 3 months.
State Changed From-To: open->closed Finally committed, thanks.