Ports net/samba-devel and net/samba-libsmbclient both use the same Samba 3, share distinfo file and other parts of the build environment. From other side, they are potentially open to desync, as maintained by different people and can be updated on a different time, forcing users to download two different versions of 10M distribution. So, my suggestion is to make libsmbclient port sub-port of samba-devel, so the PORTVERSION an distinfo as well as build environment will be in sync with each other. Fix: patch for samba-devel: patch for samba-libsmbclient: How-To-Repeat: Build both of them.
Looks good, please go ahead and commit this.
State Changed From-To: open->closed Committed, thanks!
There are still issues here: 1.) samba-devel and samba-libsmbclient still conflict with each other, which doesn't make sense. Having a client library installed must not prevent people from installing the server. Instead, samba-devel should depend on samba-libsmbclient and never install the library by itself. 2.) The slave port has stylebugs (see ports/64393).
On Wed, 7 Apr 2004 15:21:36 +0200 Michael Nottebrock <michaelnottebrock@gmx.net> wrote: >There are still issues here: > >1.) samba-devel and samba-libsmbclient still conflict >with each other, which >doesn't make sense. Having a client library installed >must not prevent people >from installing the server. This is quite compleax question, on my opinion. The problem with current approach is that samba-libsmbclient installs the most simplistic version of library, bare bones, I'd say. In a sofisticated environment it should get linked against at least LDAP and Kerberos libraries, to get wide range of ways of authentication. Well, I'm not sure here, would it use them or not... > Instead, samba-devel should >depend on >samba-libsmbclient and never install the library by >itself. My point to keep libsmbclient in samba-devel is the one, mentioned above, plus expences of double compilation of samba tree, which isn't so small. If everyone(who depend on libsmbclient) thinks it's ok, we can get rid of client library from samba-devel. >2.) The slave port has stylebugs (see ports/64393). Hm.. I've looked over the whole PR and didn't find anything, in the slave port, that conflicts with the statements there. Contrary, samba-devel itself has problems with style and doesn't validate by portlint(but thats a separate issue, that involves OPTIONS and structure of bsd.ports.mk). Can you point me, what's wrong with the slave port on your opinion? Oh, and thanks for the patch for samba-devel! With regards, Timur.
On Wednesday 07 April 2004 17:22, Timur I. Bakeyev wrote: > >1.) samba-devel and samba-libsmbclient still conflict > >with each other, which > >doesn't make sense. Having a client library installed > >must not prevent people > >from installing the server. > > This is quite compleax question, on my opinion. The > problem with current approach is that samba-libsmbclient > installs the most simplistic version of library, bare > bones, I'd say. This can probably be optionalized in the samba-libsmbclient port. > My point to keep libsmbclient in samba-devel is the one, > mentioned above, plus expences of double compilation of > samba tree, which isn't so small. If everyone(who depend > on libsmbclient) thinks it's ok, we can get rid of client > library from samba-devel. We really have to at some point. For example with the current status quo, you cannot install samba-devel when you're using KDE - because kdebase depends on samba-libsmbclient (as it only uses client functionality) and with that installed, the CONFLICTS prevents users from installing samba-devel. > >2.) The slave port has stylebugs (see ports/64393). > > Hm.. I've looked over the whole PR and didn't find > anything, in the slave port, that conflicts with the > statements there. Contrary, samba-devel itself has > problems with style and doesn't validate by portlint(but > thats a separate issue, that involves OPTIONS and > structure of bsd.ports.mk). > > Can you point me, what's wrong with the slave port on your > opinion. I can't - I guess I imagined the errors I saw, forget about it :-}. -- ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org