Bug 65272 - [PATCH] net/whois: update to 4.6.12
Summary: [PATCH] net/whois: update to 4.6.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Volker Stolz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-06 22:00 UTC by Toni Viemerö
Modified: 2004-04-13 20:00 UTC (History)
1 user (show)

See Also:


Attachments
whois-4.6.12.patch (800 bytes, patch)
2004-04-06 22:00 UTC, Toni Viemerö
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Viemerö 2004-04-06 22:00:39 UTC
- Update to 4.6.12

Port maintainer (filippo@widestore.net) is cc'd.
Comment 1 Filippo Natali 2004-04-08 08:53:10 UTC
Tested and approved, thanks!

Filippo Natali
-- 
Widestore srl
Via Borgo dei Leoni 70/F - 44100 Ferrara (Italy)
Tel +39 0532 242425 Fax +39 0532 242298 - +39 0532 213000
email: filippo.natali@widestore.net
web: http://www.widestore.net
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-04-08 15:36:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vs

I'll handle this one.
Comment 3 stolz 2004-04-08 16:13:04 UTC
A couple of small things:
- there's a hardcoded -O2 in the Makefile which could be overridden by 
MAKE_ARGS=OPTS="" in the port's Makefile
- the Makefile is so simple that with a minor modification it doesn't 
even need gmake (just replace the ifdef/endif with their FreeBSD 
counterparts .ifdef/.endif). There's already a patchfile, so this 
modification could go in there as well
- currently, some ports check WITHOUT_NLS and avoid doing the 
gettext-catalog mambo (most users really don't need them). Could you 
consider adopting this as well in your next update?

If you don't mind, I'd like to at least fix the OPTS-issue above while 
I'm about to commit this.

Volker
Comment 4 Filippo Natali 2004-04-09 15:44:07 UTC
On Thu, 8 Apr 2004 17:13:04 +0200
Volker Stolz <stolz@i2.informatik.rwth-aachen.de> wrote:

> A couple of small things:
> - there's a hardcoded -O2 in the Makefile which could be overridden by 
> MAKE_ARGS=OPTS="" in the port's Makefile
> - the Makefile is so simple that with a minor modification it doesn't 
> even need gmake (just replace the ifdef/endif with their FreeBSD 
> counterparts .ifdef/.endif). There's already a patchfile, so this 
> modification could go in there as well
> - currently, some ports check WITHOUT_NLS and avoid doing the 
> gettext-catalog mambo (most users really don't need them). Could you 
> consider adopting this as well in your next update?
> 
> If you don't mind, I'd like to at least fix the OPTS-issue above while 
> I'm about to commit this.
> 
> Volker
> 

Many thanks for your suggestions, I have almost finished to merge
them, but found I little problem.
I don't know how to convert this gmake expression to FreeBSD make
(from work/whois-4.6.12/po/Makefile):

%.mo: %.po
        msgfmt --statistics --check --verbose --output-file=$@ $<

At present I didn't found a better solution than do an explicit loop to
compile all .po files, do you have more hints? :)

best regards,
Filippo Natali
-- 
Widestore srl
Via Borgo dei Leoni 70/F - 44100 Ferrara (Italy)
Tel +39 0532 242425 Fax +39 0532 242298 - +39 0532 213000
email: filippo.natali@widestore.net
web: http://www.widestore.net
Comment 5 Volker Stolz freebsd_committer freebsd_triage 2004-04-13 11:52:40 UTC
Hrmp. I just wanted to dig out something for the changelog...
It looks like 4.6.13 is already available. It addresses an issue
present in 4.6.13. Could you please check if we should skip .12
in favour of this one?

Volker
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
rage against the finite state machine
Comment 6 Filippo Natali 2004-04-13 14:28:50 UTC
Il Mar, 2004-04-13 alle 12:52, Volker Stolz ha scritto:
> Hrmp. I just wanted to dig out something for the changelog...
> It looks like 4.6.13 is already available. It addresses an issue
> present in 4.6.13. Could you please check if we should skip .12
> in favour of this one?
> 
> Volker

Yes, I think we can skip to 4.6.13, it contains a workaround for a .de
NIC whois server bug.

Filippo Natali
-- 
Widestore srl
Via Borgo dei Leoni 70/F - 44100 Ferrara (Italy)
Tel +39 0532 242425 Fax +39 0532 242298 - +39 0532 213000
email: filippo.natali@widestore.net
web: http://www.widestore.net
Comment 7 Volker Stolz freebsd_committer freebsd_triage 2004-04-13 16:57:20 UTC
State Changed
From-To: open->closed

Committed, thanks.
Comment 8 Ceri Davies freebsd_committer freebsd_triage 2004-04-13 19:56:38 UTC
Adding to audit trail, from misfiled PR ports/65281:

From: Filippo Natali <filippo.natali@widestore.net>
Date: Wed, 7 Apr 2004 09:32:40 +0200
Message-Id: <20040407093240.115f16ec@cagnina.hq.widestore.net>
References: <200404062059.i36KxVCb000631@iso.egotaivas.com>

 On Tue, 6 Apr 2004 23:59:31 +0300 (EEST)
 Toni Viemero <toni.viemero@iki.fi> wrote:
 
 > 
 > >Submitter-Id:	current-users
 > >Originator:	Toni Viemero
 > >Organization:	
 > >Confidential:	no 
 > >Synopsis:	[PATCH] net/whois: update to 4.6.12
 > >Severity:	non-critical
 > >Priority:	low
 > >Category:	ports 
 > >Class:		update
 > >Release:	FreeBSD 5.2.1-RELEASE-p4 i386
 > >Environment:
 > System: FreeBSD iso.egotaivas.com 5.2.1-RELEASE-p4 FreeBSD 5.2.1-RELEASE-p4 #1: Wed Mar 31 21:45:56 EEST 2004
 > >Description:
 > - Update to 4.6.12
 
 Tested and approved, thanks!
 
 regards
 Filippo Natali
 -- 
 Widestore srl
 Via Borgo dei Leoni 70/F - 44100 Ferrara (Italy)
 Tel +39 0532 242425 Fax +39 0532 242298 - +39 0532 213000
 email: filippo.natali@widestore.net
 web: http://www.widestore.net