Bug 65434 - Maintainer-update: x11-wm/treewm, fixes bug with non-lowercase menu names
Summary: Maintainer-update: x11-wm/treewm, fixes bug with non-lowercase menu names
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-11 13:20 UTC by Rudolf Polzer
Modified: 2004-04-11 15:18 UTC (History)
0 users

See Also:


Attachments
file.diff (1.54 KB, patch)
2004-04-11 13:20 UTC, Rudolf Polzer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rudolf Polzer 2004-04-11 13:20:26 UTC
According to the documentation, menu names are handled case insensitively.
Unfortunately, I sent in a patch fixing another bug (which lowercased all
external commands, making menu items for programs like Eterm impossible) which
caused this bug because some other code in treewm relied upon the menu actions
being lowercased. So only menus with lowercased names worked fine after my
patch. This patch fixes the problem and leaves the other problem fixed, so now
both submenus are handled correctly case-insensitively and external commands are
left as is.

Fix: Apply this patch to /usr/ports/x11-wm/treewm:
How-To-Repeat: Use this menu structure:

  [menu]
  test=$Submenu

  [menu Submenu]
  xterm=!xterm

The submenu will not open. Changing the second line to

  test=$submenu

and leaving the rest as is helps. But this is against treewm's documentation,
hence the fix.
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-04-11 15:18:07 UTC
State Changed
From-To: open->closed

Committed, thanks!