Bug 65508 - [PATCH] net-mgmt/arpwatch: dns resolver bug
Summary: [PATCH] net-mgmt/arpwatch: dns resolver bug
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-13 23:00 UTC by Matthew George
Modified: 2004-04-14 09:37 UTC (History)
0 users

See Also:

Attachments
file.diff (281 bytes, patch)
2004-04-13 23:00 UTC, Matthew George 		no flags Details | Diff
file.shar (1.77 KB, text/plain)
2004-04-13 23:00 UTC, Matthew George 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew George 2004-04-13 23:00:38 UTC 
	This fixes the same dns bug described in ports/65501, but it has
been made to apply cleanly to the non -devel arpwatch

Fix: PORTNAME=	arpwatch
 PORTVERSION=	2.1.a11
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	net-mgmt
 MASTER_SITES=	http://www.Awfulhak.org/arpwatch/ \
 		ftp://ftp.ee.lbl.gov/

#include <ctype.h>
@@ -27,6 +27,15 @@
  	char *watchee = WATCHEE;
  	char *sendmail = PATH_SENDMAIL;
  	char *unknown = "<unknown>";
+@@ -303,7 +307,7 @@
+ 	(void)fprintf(f, "From: %s\n", watchee);
+ 	(void)fprintf(f, "To: %s\n", watcher);
+ 	hn = gethname(a);
+-	if (!isdigit(*hn))
++	if (hn != NULL)
+ 		(void)fprintf(f, "Subject: %s (%s)\n", title, hn);
+ 	else {
+ 		(void)fprintf(f, "Subject: %s\n", title);
 @@ -344,6 +348,25 @@
  		exit(1);
  	}



-- 
Matthew George
SecureWorks Technical Operations--OCPVbGUpU97W6OO6NmpOd3BwovNYHw9QLFos0e5S0SI3MMip
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig	Tue Apr 13 17:50:47 2004
+++ Makefile	Tue Apr 13 17:51:11 2004
@@ -7,7 +7,7 @@
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-04-14 06:00:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->krion

I'll take it.
Comment 2 Kirill Ponomarev freebsd_committer freebsd_triage 2004-04-14 09:36:55 UTC 
State Changed
From-To: open->closed

Committed, thanks!