Bug 65848 - [patch] Unbreak textproc/iiimf-csconv
Summary: [patch] Unbreak textproc/iiimf-csconv
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Volker Stolz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-21 13:00 UTC by Volker Stolz
Modified: 2004-05-09 21:19 UTC (History)
1 user (show)

See Also:

Attachments
iiimf-csconv (1.75 KB, text/plain)
2004-04-21 13:00 UTC, Volker Stolz 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Stolz freebsd_committer freebsd_triage 2004-04-21 13:00:42 UTC 
iiimv-cscons fails to build on bento because it use -pthread and -lc at the
same time, seemingly leading to some stack smashing, cf.
http://bento.freebsd.org/errorlogs/i386-4-full/iiimf-csconv-r11.4_1.log

cc: maintainer

Fix: Strip explicit -lc from command lines; passing -lc should never be necessary(?).
The patch below doesn't eliminate all occurrences of -lc in the port, but at
least unbreaks the build. The maintainer should investigate if this is sufficient.
Maybe the patch could be integrated into the port's current post-patch
infrastructure, but I couldn't think of a suitable regex for REINPLACE.

The patch works on -STABLE and -CURRENT.

Existing patch modified and a new patch added:
How-To-Repeat: Build the port.
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-04-29 08:35:44 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->vs

I should probably track my own PRs.
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-05-09 21:18:42 UTC 
State Changed
From-To: open->closed

Committed after maintainer timeout.