Bug 65933 - [MAINTAINER] sysutils/grub: fix non-critical bugs in UFS2 patch
Summary: [MAINTAINER] sysutils/grub: fix non-critical bugs in UFS2 patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-24 18:50 UTC by Sergey Matveychuk
Modified: 2004-06-06 14:31 UTC (History)
0 users

See Also:

Attachments
grub-0.94_3.patch (244.33 KB, patch)
2004-04-24 18:50 UTC, Sergey Matveychuk 		no flags Details | Diff
grub-4_x.patch (674 bytes, patch)
2004-06-06 00:15 UTC, Sergey Matveychuk 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Matveychuk 2004-04-24 18:50:22 UTC 
[DESCRIBE CHANGES]
* fix a few non-critical bugs in UFS2 patch

Generated with FreeBSD Port Tools 0.50
Comment 1 Pete Fritchman freebsd_committer freebsd_triage 2004-05-02 01:04:32 UTC 
State Changed
From-To: open->feedback

Do we really need to regenerate all of configure?  If so, perhaps we could 
put this patch up on personal web space or I can put it on ftp.freebsd.org, 
and/or get it integrated with the upstream distribution.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-05 16:31:38 UTC 
State Changed
From-To: feedback->closed

Feedback timeout.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-05 19:24:51 UTC 
State Changed
From-To: closed->open

Reopen, I misread the patch.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-05 19:30:53 UTC 
State Changed
From-To: open->feedback

Does not buid on 4-STABLE: 

cc -DHAVE_CONFIG_H -I. -I. -I.. -I../stage1  -Wall -Wmissing-prototypes -Wunused -Wshadow -Wpointer-arith -malign-jumps=1 -malign-loops=1 -malign-functions=1 -Wundef  -I../lib -DGRUB_UTIL=1 -DFSYS_EXT2FS=1 -DFSYS_FAT=1 -DFSYS_FFS=1 -DFSYS_UFS2=1 -DFSYS_JFS=1 -DFSYS_MINIX=1 -DFSYS_REISERFS=1 -DFSYS_VSTAFS=1 -DFSYS_XFS=1 -DUSE_MD5_PASSWORDS=1 -DSUPPORT_SERIAL=1 -DSUPPORT_HERCULES=1 -fwritable-strings -O -pipe  -c -o libgrub_a-fsys_ufs2.o `test -f 'fsys_ufs2.c' || echo './'`fsys_ufs2.c 
In file included from /usr/include/stdio.h:43, 
from /usr/include/ncurses.h:76, 
from shared.h:294, 
from fsys_ufs2.c:66: 
/usr/include/sys/cdefs.h:273: warning: `_POSIX_C_SOURCE' is not defined 
/usr/include/sys/cdefs.h:279: warning: `_POSIX_C_SOURCE' is not defined 
In file included from fsys_ufs2.c:69: 
ufs2.h:72: redefinition of `__uint8_t' 
/usr/include/machine/ansi.h:131: `__uint8_t' previously declared here 
ufs2.h:73: redefinition of `__uint16_t' 
/usr/include/machine/ansi.h:133: `__uint16_t' previously declared here 
ufs2.h:74: redefinition of `__uint32_t' 
/usr/include/machine/ansi.h:135: `__uint32_t' previously declared here 
ufs2.h:75: redefinition of `__uint64_t' 
/usr/include/machine/ansi.h:119: `__uint64_t' previously declared here 
gmake[3]: *** [libgrub_a-fsys_ufs2.o] Error 1 
gmake[3]: Leaving directory `/tmp/a/ports/sysutils/grub/work/grub-0.94/stage2' 
gmake[2]: *** [all] Error 2 
gmake[2]: Leaving directory `/tmp/a/ports/sysutils/grub/work/grub-0.94/stage2' 
gmake[1]: *** [all-recursive] Error 1 
gmake[1]: Leaving directory `/tmp/a/ports/sysutils/grub/work/grub-0.94' 
gmake: *** [all] Error 2 
*** Error code 2
Comment 5 Sergey Matveychuk 2004-06-06 00:15:33 UTC 
Hmm... It's strange. I remember I've fixed it.

Apply this patch please.

-- 
Sem.
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-06 14:31:44 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!