Bug 66217 - [maintainer update] NO_PACKAGE for devel/ocaml-findlib
Summary: [maintainer update] NO_PACKAGE for devel/ocaml-findlib
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-03 19:50 UTC by Stephane Legrand
Modified: 2004-05-09 17:18 UTC (History)
0 users

See Also:


Attachments
file.diff (621 bytes, patch)
2004-05-03 19:50 UTC, Stephane Legrand
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephane Legrand freebsd_committer freebsd_triage 2004-05-03 19:50:23 UTC
  ocaml-findlib should always be compiled because it then can build
  several useful META files.
  I hope this will fix the compilation of www/ocaml-net.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-05-03 21:30:13 UTC
We can't build those meta files and package them?

Setting NO_PACKAGE would prevent packaging of all ports depending on
this on Bento.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

You can't expect to wield supreme executive power just 'cause some
watery tart threw a sword at you.
Comment 2 Stephane Legrand freebsd_committer freebsd_triage 2004-05-03 23:21:18 UTC
On Mon, May 03, 2004 at 10:30:13PM +0200, Pav Lucistnik wrote:
> We can't build those meta files and package them?

I don't know all the tricky details but my understanding is that
it would be difficult. Notably because these META files seem dependent
on the compiler options (x11/no x11, tk/no tk, threads support,
whatever...).

Note that this port is a small one. On my goold old PII 233Mhz,
47 seconds is needed to install it. And, as findlib is used when
you want to compile an ocaml project, you will certainly have to
install the compiler.

> Setting NO_PACKAGE would prevent packaging of all ports depending on
> this on Bento.
 
All ports ? Really ? I didn't know that, i thought that it would
only affect ocaml-findlib. Well, i will try to contact the author
of findlid to look for a better solution (if there is one). Otherwise,
i think it's unfortunately the safer workaround.


Regards,
Stephane.

-- 
Je recherche un emploi de développeur/admin. sys.
 (FreeBSD,Linux,PHP,Perl,MySQL,OCaml,Tcl/Tk...)
    ==> http://stephleg.free.fr/cv.pdf <==
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-05-04 09:42:58 UTC
V út, 04. 05. 2004 v 00:21, Stephane Legrand pí¹e:

> > We can't build those meta files and package them?
> 
> I don't know all the tricky details but my understanding is that
> it would be difficult. Notably because these META files seem dependent
> on the compiler options (x11/no x11, tk/no tk, threads support,
> whatever...).


This is not the problem, packages are expected to reflect the system
they were built on, not the system they are being installed into.

I suppose a port have some default options (x11,tk,threads) and
installing port on clean installation of FreeBSD would produce these
default options. Package will have same default options.



-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

End users have trouble keeping food off their keyboard and sorting messages
in Outlook. Try explaining this problem to them.
Comment 4 Stephane Legrand freebsd_committer freebsd_triage 2004-05-07 15:39:37 UTC
On Tue, May 04, 2004 at 10:42:58AM +0200, Pav Lucistnik wrote:
> V út, 04. 05. 2004 v 00:21, Stephane Legrand píše:
> 
> > > We can't build those meta files and package them?
> > 
> > I don't know all the tricky details but my understanding is that
> > it would be difficult. Notably because these META files seem dependent
> > on the compiler options (x11/no x11, tk/no tk, threads support,
> > whatever...).
> 
> This is not the problem, packages are expected to reflect the system
> they were built on, not the system they are being installed into.
> 
> I suppose a port have some default options (x11,tk,threads) and
> installing port on clean installation of FreeBSD would produce these
> default options. Package will have same default options.

You are right. Here is my new patch: 


diff -ruN ocaml-findlib-orig/Makefile ocaml-findlib/Makefile
--- ocaml-findlib-orig/Makefile	Thu May  6 22:54:56 2004
+++ ocaml-findlib/Makefile	Thu May  6 23:21:04 2004
@@ -13,7 +13,7 @@
 MASTER_SITES=	http://www.ocaml-programming.de/packages/
 PKGNAMEPREFIX=	ocaml-
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	stephane@FreeBSD.org
 COMMENT=	OCaml package manager
 
 BUILD_DEPENDS=	ocamlc:${PORTSDIR}/lang/ocaml
@@ -29,6 +29,13 @@
 post-install:
 	@${FIND} ${PREFIX}/lib/ocaml/site-lib/findlib -type f | \
 		${SED} 's,^${PREFIX}/,,' >> ${TMPPLIST}
+
+# this list comes from the findlib configure script
+.for D in dbm dynlink graphics num num-top str threads unix stdlib bigarray labltk camlp4
+	@${FIND} ${PREFIX}/lib/ocaml/site-lib/$D -type f -name META | \
+		${SED} 's,^${PREFIX}/,,' >> ${TMPPLIST}
+.endfor
+
 	@${FIND} ${PREFIX}/lib/ocaml/site-lib/findlib -type d | ${SORT} -r | \
 		${SED} 's,^${PREFIX}/,@dirrm ,' >> ${TMPPLIST}
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2004-05-09 17:18:09 UTC
State Changed
From-To: open->closed

Your last patch was committed. Please note there are still 
leftover files: 

list of extra files and directories in / 
usr/local/lib/ocaml/site-lib extra 
usr/local/lib/ocaml/topfind extra 
-rw-r--r--  1 root  wheel  443  9 kvu011b 16:15 /usr/local/lib/ocaml/topfind 

/usr/local/lib/ocaml/site-lib: 
total 2 
drwxr-xr-x  2 root  wheel  512  9 kvu011b 16:15 num-top 

/usr/local/lib/ocaml/site-lib/num-top: 
total 12 
-rw-r--r--  1 root  wheel  6244  9 kvu011b 16:15 num_top.cma 
-rw-r--r--  1 root  wheel   120  9 kvu011b 16:15 num_top.cmi 
-rw-r--r--  1 root  wheel   793  9 kvu011b 16:15 num_top_printers.cmi