A simple change to make ports/mail/spamass-milter rely on RC_SUBR. I've also updated files/activation.txt to reflect the fact that spamd now uses RC_SUBR too, so no need for the cp/chmod stuff. Also, the PID stuff that was in PORTREVISION=1 seemed to be, well, quite broken. The PID file would never have the correct ID, for obvious reasons. Port committer should note the following: * files/spamass-milter.sh.dist has been removed * files/spamass-milter.sh needs a FreeBSD CVS ID (note tag at top of file) * Should make sure /usr/ports/UPDATING gets updated with info about how we now use spamass_milter_enable rc.conf(5) tweaks. Maintainer has been CC'd. Fix: See attached patch. How-To-Repeat: Not applicable.
Dear maintainer of FreeBSD port mail/spamass-milter, please take a look at http://www.freebsd.org/cgi/query-pr.cgi?q=66851 Do you approve this patch? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> With sufficient thrust, pigs fly just fine. -- RFC 1925
State Changed From-To: open->feedback Asked maintainer for approval.
Responsible Changed From-To: freebsd-ports-bugs->pav Handle.
Pav Lucistnik wrote: >Dear maintainer of FreeBSD port mail/spamass-milter, please take a look >at > >http://www.freebsd.org/cgi/query-pr.cgi?q=66851 > >Do you approve this patch? > > The patch seems to be fine. Tested on a 5-current machine and it works. However, as a side note I have to disagree with the submitter's assessment that the current PID file handling is broken. It seems that he missed the -f option (`run in foreground'). The process ID in $! *is* the correct daemon process ID if the daemon is run in foreground, also for obvious reasons. :D Thanks, Eugene
State Changed From-To: feedback->closed Committed, thanks!