Bug 67834 - Maintainer update: net/isc-dhcp3-server (UNIQUENAME fix)
Summary: Maintainer update: net/isc-dhcp3-server (UNIQUENAME fix)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-11 15:40 UTC by Cyrille Lefevre
Modified: 2004-06-18 08:41 UTC (History)
0 users

See Also:


Attachments
file.diff (451 bytes, patch)
2004-06-11 15:40 UTC, Cyrille Lefevre
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cyrille Lefevre 2004-06-11 15:40:14 UTC
if options are sets for one of the sub-ports, the others sub-ports
don't ask for the options.

Makefile
PORTREVISION does not need to be bumped, IMHO
UNIQUENAME initialized to $PKGBASE

How-To-Repeat: cd ports/net/isc-dhcp3-client
make
(the options dialog is shown)
cd ports/net/isc-dhcp3-server
make
(the options dialog isn't shown)
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-06-17 12:59:22 UTC
Somehow doesn't work:

isc-dhcp3-server@menelaos [13:58:01]> make -V PKGBASE
isc-dhcp3-server

Patching file Makefile using Plan A...
Hunk #1 succeeded at 24.
Hmm...  Ignoring the trailing garbage.
done
isc-dhcp3-server@menelaos [13:57:08]> make
===> Using wrong configuration file /var/db/ports//options
*** Error code 1

Stop in /usr/ports/net/isc-dhcp3-server.

Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-06-17 12:59:53 UTC
State Changed
From-To: open->feedback

Doesn't work as advertised?
Comment 3 Cyrille Lefevre 2004-06-17 14:53:12 UTC
On Jun 17, 2004 01:59:22 pm +0200, Volker Stolz wrote:
> Somehow doesn't work:
> 
> isc-dhcp3-server@menelaos [13:58:01]> make -V PKGBASE
> isc-dhcp3-server
> 
> Patching file Makefile using Plan A...
> Hunk #1 succeeded at 24.
> Hmm...  Ignoring the trailing garbage.
> done
> isc-dhcp3-server@menelaos [13:57:08]> make
> ===> Using wrong configuration file /var/db/ports//options
> *** Error code 1
> 
> Stop in /usr/ports/net/isc-dhcp3-server.

ok, PKGBASE is not yet know when needed.

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/isc-dhcp3-server/Makefile,v
retrieving revision 1.95
diff -u -I$Id.*$ -I$.+BSD.*$ -r1.95 Makefile
--- Makefile	1 Jun 2004 13:34:27 -0000	1.95
+++ Makefile	17 Jun 2004 13:49:08 -0000
@@ -24,6 +24,7 @@
 
 SUBSYS?=	server
 
+UNIQUENAME=	${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}	# ${PKGBASE}
 .if ${SUBSYS} == client
 OPTIONS=	INTERFACE_POLLING "interface polling support" on
 .endif

Cyrille.
-- 
Cyrille Lefevre
-- 
mailto:cyrille.lefevre@laposte.net
Comment 4 Volker Stolz freebsd_committer freebsd_triage 2004-06-18 08:40:57 UTC
State Changed
From-To: feedback->closed

Committed, thanks!