Bug 67913 - [PATCH] multimedia/mplayer-gtk-esound: fix build if WITH_GTK2 defined
Summary: [PATCH] multimedia/mplayer-gtk-esound: fix build if WITH_GTK2 defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-14 01:00 UTC by Jon Noack
Modified: 2004-06-14 15:48 UTC (History)
1 user (show)

See Also:

Attachments
mplayer-gtk-esound-0.99.4.patch (1.38 KB, patch)
2004-06-14 01:00 UTC, Jon Noack 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Noack 2004-06-14 01:00:46 UTC 
Building mplayer with WITH_GTK2 defined dies with errors on line 925 
of vidix/drivers/radeon_vid.c ('Display' undefined or something).  I 
think GTK detection "falls through the cracks" and CFLAGS are set 
incorrectly.  The attached patch makes it just fall back to WITH_GTK1. 
 Other ports use the WITH_GTK2 knob (I have it in /etc/make.conf), so 
we should either fall back to GTK1 or fail.  If it were to just fail, 
most users would manually define WITH_GTK1 anyway and try again, so I 
think falling back to GTK1 is the best option.  However, I can 
understand why some may not like it bringing in dependencies they 
didn't ask for.  This does at least print that it's using GTK1...

Port maintainer (riggs@rrr.de) is cc'd.

Generated with FreeBSD Port Tools 0.50
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-14 15:48:16 UTC 
State Changed
From-To: open->closed

Committed, thanks!