Bug 67923 - [PATCH] multimedia/mplayer: Fails to build when WITH_GTK1 knob not set.
Summary: [PATCH] multimedia/mplayer: Fails to build when WITH_GTK1 knob not set.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-14 06:40 UTC by Tom McLaughlin
Modified: 2004-06-14 18:28 UTC (History)
1 user (show)

See Also:

Attachments
mplayer_radeon.diff (877 bytes, patch)
2004-06-14 06:40 UTC, Tom McLaughlin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom McLaughlin 2004-06-14 06:40:18 UTC 
Mplayer fails to build when the WITH_GTK1 knob is not set because the videx 
radeon and rage128 drivers require X11 include files.  The WITH_GTK1 knob 
adds the --enable-gui configure argument which automatically adds their 
location when compiling.  If this is not set then currently the build will fail.  
Attached patch corrects the Makefile for these drivers so that the X11 
includes are always used when compiling them.

This is the same problem reported in PR 67913 but that patch does not fix 
the problem when building with the WITHOUT_GUI knob set.

Maintainer CC'ed on PR.


Port build error output:

cc -c -I../libvo/ -I../../libvo -O -pipe   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include/freetype2 -I/usr/local/include  -fPIC -I. -I.. -o radeon_vid.o radeon_vid.c
radeon_vid.c:29:22: X11/Xlib.h: No such file or directory
radeon_vid.c: In function `probe_fireGL_driver':
radeon_vid.c:925: error: `Display' undeclared (first use in this function)
radeon_vid.c:925: error: (Each undeclared identifier is reported only once
radeon_vid.c:925: error: for each function it appears in.)
radeon_vid.c:925: error: `dp' undeclared (first use in this function)
radeon_vid.c:927: warning: initialization makes pointer from integer without a cast
gmake[2]: *** [radeon_vid.o] Error 1
gmake[2]: Leaving directory `/usr/ports/multimedia/mplayer.old/work/MPlayer-1.0pre4/vidix/drivers'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/ports/multimedia/mplayer.old/work/MPlayer-1.0pre4/vidix'
gmake: *** [vidix/libvidix.a] Error 2
*** Error code 2
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-14 09:40:55 UTC 
Responsible Changed
From-To: freebsd-advocacy->freebsd-ports-bugs

Reclassify
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-14 15:48:48 UTC 
State Changed
From-To: open->closed

Fix committed.