"post-patch" editing of ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} is broken/insufficient when ${LOCALBASE} is not '/usr/local' (the hard coded value in Template::Toolkit's Makefile.PL). Since the post-patch is useless on this system, port installs the optional (as described by TT) files under /usr/local/tt2 instead of /misc/local/share/tt2, breaking later the packaging of the port. Below is some abbreviated log, w/ BATCH option given for package make-ing, ... ... You can chose any directory for the installation of the additional Template Toolkit components. The proposed default assumes a Unix flavour to your operating system (suggestions for suitable defaults for other platforms welcome). Installation directory [/usr/local/tt2] /usr/local/tt2 ... Installing /misc/local/lib/perl5/5.8.4/man/man3/Template::Tutorial::Datafile.3 Installing /misc/local/lib/perl5/5.8.4/man/man3/Template::Plugin::XML::Simple.3 Installing /misc/local/lib/perl5/5.8.4/man/man3/Template::Plugin::GD::Graph::lines.3 Installing /misc/local/bin/tpage Installing /misc/local/bin/ttree Writing /misc/local/lib/perl5/site_perl/5.8.4/mach/auto/Template/.packlist Installing optional components into /usr/local/tt2 + docs + examples + images + templates Weaving the rainbow: blowing colour into Splash! GIFs src: /usr/local/tt2/images/splash/black dest: /usr/local/tt2/images/splash/* ... Source: /usr/local/tt2/docs/src Destination: /usr/local/tt2/docs/html Include Path: [ /usr/local/tt2/docs/style/splash, /usr/local/tt2/docs/lib, /usr/local/tt2/templates ] Ignore: [ ] Copy: [ ] Accept: [ ] Suffix: [ ] + index.html + Manual/Plugins.html + Manual/Filters.html + Manual/Internals.html ... + Release/INSTALL.html + FAQ/FAQ.html + FAQ/index.html ttree 2.75 (Template Toolkit version 2.13) Source: /usr/local/tt2/examples/src Destination: /usr/local/tt2/examples/html Include Path: [ /usr/local/tt2/examples/lib, /usr/local/tt2/templates ] Ignore: [ ] Copy: [ ] Accept: [ ] Suffix: [ ] + splash/button.html + splash/tab.html + splash/menu.html ... ===> Registering installation for p5-Template-Toolkit-2.13 ===> Building package for p5-Template-Toolkit-2.13 tar: share/tt2/docs/README: Cannot stat: No such file or directory tar: share/tt2/docs/html/FAQ/FAQ.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/FAQ/index.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Library/HTML.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Library/PostScript.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Library/Splash.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Library/index.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Manual/Config.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Manual/Credits.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Manual/Directives.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Manual/Filters.html: Cannot stat: No such file or directory tar: share/tt2/docs/html/Manual/Internals.html: Cannot stat: No such file or directory ... tar: share/tt2/templates/splash/tabset: Cannot stat: No such file or directory tar: share/tt2/templates/splash/text: Cannot stat: No such file or directory tar: share/tt2/templates/splash/ttdotorg: Cannot stat: No such file or directory tar: share/tt2/templates/splash/ttpower: Cannot stat: No such file or directory tar: Error exit delayed from previous errors pkg_create: make_dist: tar command failed with code 512 Creating package /misc/ports/www/p5-Template-Toolkit/p5-Template-Toolkit-2.13.tgz Registering depends: p5-AppConfig-1.56 p5-File-Temp-0.12_1 perl-5.8.4. Creating gzip'd tar ball in '/misc/ports/www/p5-Template-Toolkit/p5-Template-Toolkit-2.13.tgz' *** Error code 1 Stop in /misc/ports/www/p5-Template-Toolkit. Fix: As ${LOCALBASE} cannot be always guaranteed to be '/usr/local' -- the hard coded value in Makefile.PL of TT -- change it to the real value. No problem occurred w/ deinstall-ing, reinstall-ing, and packag-ing after the follwing patch for www/p5-Template-Toolkit/Makefile ... How-To-Repeat: Set $LOCALBASE to something else other than /usr/local, not set $PREFIX, then try to make package.
On Tue, Jun 29, 2004 at 02:20:11AM -0400, parv@pair.com wrote: > As ${LOCALBASE} cannot be always guaranteed to be '/usr/local' -- the > hard coded value in Makefile.PL of TT -- change it to the real value. > No problem occurred w/ deinstall-ing, reinstall-ing, and packag-ing > after the follwing patch for www/p5-Template-Toolkit/Makefile ... > > --- Makefile.old Tue Jun 29 02:10:06 2004 > +++ Makefile Tue Jun 29 02:03:08 2004 > @@ -119,7 +119,7 @@ > Template::View.3 > > post-patch: > - ${PERL} -pi -e 's,${LOCALBASE}/tt2,${PREFIX}/share/tt2,g' \ > + ${PERL} -pi -e 's,/usr/local/tt2,${PREFIX}/share/tt2,g' \ > ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} > > .if ${PERL_LEVEL} >= 500800 Yeah. The reverse to your patch was introduced in rev. 1.4 of the Makefile with a comment "Satisfy portlint". \Anton. -- Floating point will almost always have enough precision for the task at hand, and by the time it doesn't, it will. :-) -- Larry Wall
State Changed From-To: open->closed Fix committed, thanks!