Add an option (QMAILSCAN_LANG) to select language of notifies. Port maintainer (freebsd@simplerezo.com) is cc'd. Generated with FreeBSD Port Tools 0.50
Dear maintainer, please review the proposed patch! Volker
State Changed From-To: open->feedback Forwarded PR to maintainer
=20 Hi, This patch is useless. Qmail-Scanner use LANG variable from your environnement to "detect" the appropriate language. Obviously, you can specify it on command line: #LANG=3Djp_JP make So no needs to define new configuration option like QMAILSCAN_LANG. Regards, Clement=20 -----Message d'origine----- De : Volker Stolz [mailto:vs@freebsd.org] Envoy=E9 : vendredi 9 juillet = 2004 15:11 =C0 : freebsd-gnats-submit@freebsd.org; renato@galle.com.br; freebsd@simplerezo.com Objet : Re: ports/68770: [PATCH] = mail/qmail-scanner: Add an option to select language Dear maintainer, please review the proposed patch! Volker
On Sun, Jul 11, 2004 at 04:46:11PM +0200, Clément MOULIN wrote: > This patch is useless. > Qmail-Scanner use LANG variable from your environnement to "detect" the > appropriate language. > > Obviously, you can specify it on command line: > #LANG=jp_JP make Hm, I'm not sure that this is a good idea either -- this would mean that the environment influences the build when using 'sudo'. I just checked, export LANG=de; sudo bash -c set | grep LANG reveals that LANG remains set. I can't nail you down to specific instructions, but I think this should be considered rather a bug than a feature. Volker -- http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME Neu! Ändern Sie den Anfangstag Ihrer Woche
State Changed From-To: feedback->closed Maintainer rejected the patch.
Volker Stolz wrote: > On Sun, Jul 11, 2004 at 04:46:11PM +0200, Cl=E9ment MOULIN wrote: >> This patch is useless. >> Qmail-Scanner use LANG variable from your environnement to "detect" = the >> appropriate language. >> >> Obviously, you can specify it on command line: >> #LANG=3Djp_JP make > > Hm, I'm not sure that this is a good idea either -- this would mean=20= > that > the environment influences the build when using 'sudo'. I just = checked, > export LANG=3Dde; sudo bash -c set | grep LANG reveals that LANG = remains > set. I can't nail you down to specific instructions, but I think this > should be considered rather a bug than a feature. You my two cents: since LANG influences sed, grep and other text=20 processing utilities I'm not sure whether it is a good idea to build=20 ports with LANG set. We might decide to sanitize the environment when=20 building ports should this turn out to cause problems, so I would=20 suggest to either make clear that other languages are unsupported or to=20= make the configuration explicit. Implicit configuration inherited by the=20= build environment is always fragile and should be made explicit. -Oliver