Bug 68885 - New port: x11-themes/phase An original Qt/KDE widget style
Summary: New port: x11-themes/phase An original Qt/KDE widget style
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-10 06:20 UTC by David Johnson
Modified: 2004-08-01 19:48 UTC (History)
0 users

See Also:

Attachments
phase.shar (2.33 KB, text/plain)
2004-07-10 06:20 UTC, David Johnson 		no flags Details
phase.diff (1.55 KB, patch)
2004-07-29 05:12 UTC, David Johnson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Johnson 2004-07-10 06:20:22 UTC 
An original Qt/KDE widget style.
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2004-07-25 14:33:23 UTC 
State Changed
From-To: open->feedback

Does not compile on my STABLE: 

c++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include -I/usr/X11R6/include -I/usr/local/include -pthread -DQT_THREAD_SUPPORT -I/usr/local/include -I/usr/local/include -I/usr/X11R6/include -D_GETOPT_H -D_THREAD_SAFE -O2 -O -pipe -fno-exceptions -fno-check-new -DQT_PLUGIN -c phasestyle.cc -Wp,-MD,.deps/phasestyle.TPlo  -fPIC -DPIC -o .libs/phasestyle.o 
phasestyle.cc: In method `void PhaseStyle::drawKStylePrimitive(KStyle::KStylePrimitive, QPainter *, const QWidget *, const QRect &, const QColorGroup &, unsigned int = Style_Default, const QStyleOption & = QStyleOption::Default) const': 
phasestyle.cc:1088: comparison of distinct pointer types `const QSlider *' and `QWidget *const' lacks a cast 
phasestyle.cc: In method `void PhaseStyle::drawComplexControl(QStyle::ComplexControl, QPainter *, const QWidget *, const QRect &, const QColorGroup &, unsigned int = Style_Default, unsigned int = SC_All, unsigned int = SC_None, const QStyleOption & = QStyleOption::Default) const': 
phasestyle.cc:1622: comparison of distinct pointer types `const QComboBox *' and `QWidget *const' lacks a cast 
phasestyle.cc:1777: comparison of distinct pointer types `const QSpinWidget *' and `QWidget *const' lacks a cast 

Can you investigate?
Comment 2 David Johnson 2004-07-25 19:45:39 UTC 
My investigation does not find a problem. This compiles fine under 
gcc-3.3.3. -Wall and -pedantic issue no warnings in this area. These 
are standard pointer comparisons between base and derived types, so the 
casting should be implicit. In addition, my x11-themes/qinx port was 
recently committed, and it uses the exact same construct. I suspect 
that the problem is elsewhere. If necessary I can provide a patch to 
perform explicit casting in the worst case.
Comment 3 David Johnson 2004-07-29 05:12:11 UTC 
Attached is a diff of the earlier shar that includes a patch to work 
with gcc-2.95 on -STABLE.
Comment 4 Tilman Keskinoz freebsd_committer freebsd_triage 2004-08-01 19:48:47 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!