Bug 69043 - Fix BROKEN status of multimedia/mpeg4ip on amd64
Summary: Fix BROKEN status of multimedia/mpeg4ip on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mario Sergio Fujikawa Ferreira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-14 05:40 UTC by Conrad J. Sabatier
Modified: 2004-07-18 18:59 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad J. Sabatier 2004-07-14 05:40:23 UTC
	multimedia/mpeg4ip is marked as BROKEN for amd64:

===>  mpeg4ip-1.0 is marked as broken: Does not build on amd64 (shared 
libraries must be compiled with -fPIC).

	So why not just add the needed flag if ${ARCH} == amd64?

Fix: Workaround: add the following to portupgrade's 
	/usr/local/etc/pkgtools.conf under the MAKE_ARGS section:

	'multimedia/mpeg4ip' => 'CFLAGS+="-fPIC"',

	Or patch the port's Makefile:



.if ${ARCH} == "amd64"
-BROKEN=                "Does not build on amd64 (shared libraries must be compiled with -fPIC)"
+       CFLAGS+="-fPIC"
 .endif

 post-patch:--gP3YdCYsMqflTBspCwSe3AV2lKEUJOV5dl3zeZE9nvWv8ZHI
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/multimedia/mpeg4ip/Makefile,v
retrieving revision 1.39
diff -u -r1.39 Makefile
--- Makefile    19 Jun 2004 09:26:08 -0000      1.39
+++ Makefile    14 Jul 2004 04:30:23 -0000
@@ -92,7 +92,7 @@
 .include <bsd.port.pre.mk>
How-To-Repeat: 	Try to build multimedia/mpeg4ip on amd64
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-07-14 12:53:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lioux

Over to maintainer.
Comment 2 Kris Kennaway 2004-07-16 10:31:32 UTC
On Tue, Jul 13, 2004 at 11:35:43PM -0500, Conrad J. Sabatier wrote:

> 	So why not just add the needed flag if ${ARCH} == amd64?

Because that compiles everything with -fPIC (instead of the files that
need it), and is a pessimization.

Kris
Comment 3 Mario Sergio Fujikawa Ferreira freebsd_committer freebsd_triage 2004-07-18 18:59:45 UTC
State Changed
From-To: open->closed

Committed, thanks!