Bug 69669 - Update port: dns/dnrd version 2.14
Summary: Update port: dns/dnrd version 2.14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-27 17:00 UTC by Natanael Copa
Modified: 2004-07-28 21:53 UTC (History)
0 users

See Also:


Attachments
file.shar (3.00 KB, text/plain)
2004-07-27 17:00 UTC, Natanael Copa
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Natanael Copa 2004-07-27 17:00:42 UTC
	Update of dnrd. 2.14. New Makefile, new description, new
website. rc.d script added.

Fix: This is my first port (not last...) and I'm new to freebsd. I hope I
have done everything correctly. Please let me know if I could make it
easier for you in anyway.

There is a file, COPYING, that proably shouldn't be installed but I
dont know the proper way to remove it. (patch-COPYING? "rm" in
post-install?)
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-07-28 21:16:02 UTC
State Changed
From-To: open->closed

A lot of mistakes in your submissions: 

- updates to existing ports are usually submitted in diff -ruN format 
between old and new port directory. Details are in Porter's Handbook. 
- man pages must be listed in MANX= macro in Makefile, not in pkg-plist 
- port as you sent it does not fetch (download .tar.gz file), you used 
${MASTER_SITE_SOURCEFORGE} but forgot to define MASTER_SITE_SUBDIR 
- you forgot to provide distinfo file 
- there is no USE_GNUMAKE. the macro is named USE_GMAKE 
- rc script incorrectly handle default values, not allowing user to 
change dnrd_enable is quite inconvenient 
- your port does not compile on FreeBSD 4.x 
- due to header inclusion problems 
- due to threading library misdetection in configure script 
- your port is not prefix clean. again, necessary patching was 
present in old port 
- you haven't added rc script into pkg-plist 

I fixed all these issues and committed the update into CVS.