Bug 69857 - www/wml: unbreak with some cleaning.
Summary: www/wml: unbreak with some cleaning.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-31 23:20 UTC by Thierry Thomas
Modified: 2004-08-02 18:52 UTC (History)
1 user (show)

See Also:


Attachments
wml.diff (5.18 KB, patch)
2004-07-31 23:20 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas 2004-07-31 23:20:14 UTC
	- fix pkg-plist and unbreak;
	- use libtool;
	- add PNG support.

	Note: this port is still marked broken on amd64 (needs to build
	shared libraries with -fPIC) but -fPIC seems used...

Fix: I will apply the following patch if maintainer agrees:
How-To-Repeat: 	N/A.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2004-07-31 23:21:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->thierry


Handle.
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2004-07-31 23:22:17 UTC
State Changed
From-To: open->feedback


Wainting for maintainer's approval.
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2004-08-01 16:16:31 UTC
Le Dim  1 aoû 04 à 15:41:19 +0200, Christian Lackas <delta@lackas.net>
 écrivait :
> * Thierry Thomas <thierry@FreeBSD.org> [040801 00:45]:
> 
> Hallo Thomas,


Hello,

> > Your port www/wml is a dependency of my port textproc/cdsware, then I
> > have tried to unbreak it.
> > Could you please check my PR?
> 
> there is still a problem with the plist. On my system he installs the
> Perl libraries into 
> 
>     /usr/local/lib/wml/perl/lib/i386-freebsd-64int
> 
> So, we have to replace %%ARCH%% in plist with
> 
>     perl -MConfig -we 'print $Config{archname}'
> 
> But right now I do not now how to tell the Makefile. I tried some things
> like:
> 
>     PERLARCH != perl -MConfig -we 'print $Config{archname}'
>     PLIST_SUB+= ARCH=${PERLARCH}
> 
> But it does not work. Maybe you have more luck :-).


OK, I see. What about this patch:

--- wml.2.diff begins here ---
--- www/wml.orig/Makefile	Sun Jul 25 22:52:33 2004
+++ www/wml/Makefile	Sun Aug  1 17:07:32 2004
@@ -18,7 +18,7 @@
 USE_REINPLACE=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--with-perl=${PERL5}
-PLIST_SUB+=	ARCH=${ARCH}-freebsd
+PLIST_SUB+=	ARCH=${LOCAL_PERL_ARCH}
 
 BROKEN=		"Broken pkg-plist"
 
@@ -54,6 +54,8 @@
 MAN7=	wml_intro.7 wml_macros.7 wml_tutorial.7 wml_faq.7 wml_tags.7
 
 .include <bsd.port.pre.mk>
+
+LOCAL_PERL_ARCH!=	${PERL5} -MConfig -e 'print "$$Config{archname}"'
 
 .if ${ARCH} == "amd64"
 BROKEN=		"Build fails on amd64 (needs to build shared libraries with -fPIC)"
--- wml.2.diff ends here ---

Note: I cannot test it myself, since this does not change anything for me!

Regards,
-- 
Th. Thomas.
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2004-08-02 18:52:22 UTC
State Changed
From-To: feedback->closed


Committed with maintainer's approval.