Bug 71001 - [PATCH] audio/ices: respect CFLAGS during compile :)
Summary: [PATCH] audio/ices: respect CFLAGS during compile :)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-26 20:10 UTC by Paul Seniura
Modified: 2004-08-26 21:22 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Seniura 2004-08-26 20:10:19 UTC 
The FreeBSD port skeleton Makefile for audio/ices wipes
out CFLAGS set in /etc/make.conf and/or elsewhere.

Fix: Apply this patch to the port-side Makefile
(not the original project):


===cut-here===


We couldn't get this port to compile with -mcpu=pentium2
et al. until this patch is applied. 

The project's own makefile adds its own -f flags to
induce more optimizations.  This will continue to
be proper after this patch.


  --  thx, Paul Seniura
           System Specialist
           State of Okla. D.O.T.--QOzvQDUtcKijl6qsDoFoO0qEb8rIv0khAfll7bverfr3Jhwl
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile_orig	Wed Aug 25 17:00:06 2004
+++ Makefile	Thu Aug 26 12:20:04 2004
@@ -18,7 +18,7 @@
 		vorbis.3:${PORTSDIR}/audio/libvorbis \
 		xml2.5:${PORTSDIR}/textproc/libxml2
 
-CONFIGURE_ENV=	CFLAGS="${PTHREAD_CFLAGS} -I${LOCALBASE}/include" \
+CONFIGURE_ENV=	CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS} -I${LOCALBASE}/include" \
 		LDFLAGS="${PTHREAD_LIBS} -L${LOCALBASE}/lib"
 USE_GMAKE=	yes
 USE_LIBTOOL_VER=	13
===cut-here===
How-To-Repeat: 
Set CFLAGS in /etc/make.conf. 
Let the app build normally. 
See no specified CFLAGS in the report output.
Comment 1 Michael Nottebrock freebsd_committer freebsd_triage 2004-08-26 21:22:13 UTC 
State Changed
From-To: open->closed

Committed, thanks.