Update to new 4.1.1 version. The former 4.0.1 is not fetchable from master site anymore. Maintainer cc'd. Fix: Patch to be applied from within /usr/ports or a local ports tree
Hello, It's tested and looks nice. But I think, instead of post-install: @${PYTHON_CMD} -O -c "import sipconfig" you have decided to add to Makefile (that is certainly a good idea), it would be better to add post-install: @${PYTHON_CMD} -c "import sipconfig" @${PYTHON_CMD} -O -c "import sipconfig" to generate both .pyc and .pyo AND then delete files/patch-aa as it will be no longer necessary to have it after that. -- Eugene Ossintsev
Replacing patch as suggested by maintainer (I agree): [ the change is to also compile sipconfig.pyc in the post-install stage which enables to delete all of files/] diff -ruN devel/py-sip/Makefile devel/py-sip.new/Makefile --- devel/py-sip/Makefile Wed Sep 29 01:35:27 2004 +++ devel/py-sip.new/Makefile Wed Sep 29 01:31:58 2004 @@ -5,7 +5,7 @@ # $FreeBSD: ports/devel/py-sip/Makefile,v 1.11 2004/07/08 20:04:32 krion Exp $ PORTNAME= sip -PORTVERSION= 4.0.1 +PORTVERSION= 4.1.1 CATEGORIES= devel python MASTER_SITES= http://www.river-bank.demon.co.uk/download/sip/ PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -18,10 +18,16 @@ USE_PYTHON= yes USE_QT_VER= 3 +.include <bsd.port.pre.mk> + do-configure: @(cd ${WRKSRC} && ${SETENV} QTDIR=${X11BASE} \ QMAKESPEC=${LOCALBASE}/share/qt/mkspecs/freebsd-g++ \ ${PYTHON_CMD} configure.py -b ${PREFIX}/bin \ -d ${PYTHONPREFIX_SITELIBDIR} -v ${PREFIX}/share/sip) -.include <bsd.port.mk> +post-install: + @${PYTHON_CMD} -c "import sipconfig" + @${PYTHON_CMD} -O -c "import sipconfig" + +.include <bsd.port.post.mk> diff -ruN devel/py-sip/distinfo devel/py-sip.new/distinfo --- devel/py-sip/distinfo Wed Sep 29 01:35:27 2004 +++ devel/py-sip.new/distinfo Tue Sep 28 11:56:32 2004 @@ -1,2 +1,2 @@ -MD5 (sip-4.0.1.tar.gz) = a2aa4ef53cb4f18e7ce25bc2e123548e -SIZE (sip-4.0.1.tar.gz) = 289533 +MD5 (sip-4.1.1.tar.gz) = f9dc81a7726305af114fede6c4107ce6 +SIZE (sip-4.1.1.tar.gz) = 296512 diff -ruN devel/py-sip/files/patch-aa devel/py-sip.new/files/patch-aa --- devel/py-sip/files/patch-aa Wed Sep 29 01:35:27 2004 +++ devel/py-sip.new/files/patch-aa Thu Jan 1 01:00:00 1970 @@ -1,11 +0,0 @@ ---- configure.py.orig Sat Jul 3 00:17:35 2004 -+++ configure.py Sat Jul 3 00:18:18 2004 -@@ -688,7 +688,7 @@ - sipconfig.ParentMakefile( - configuration=cfg, - subdirs=["sipgen", "siplib"], -- installs=("sipconfig.py", cfg.sip_mod_dir) -+ installs=(["sipconfig.py", "sipconfig.pyc"], cfg.sip_mod_dir) - ).generate() - - sipconfig.inform("Creating sip code generator Makefile...") diff -ruN devel/py-sip/pkg-plist devel/py-sip.new/pkg-plist --- devel/py-sip/pkg-plist Wed Sep 29 01:35:27 2004 +++ devel/py-sip.new/pkg-plist Tue Sep 28 19:24:18 2004 @@ -3,3 +3,4 @@ %%PYTHON_SITELIBDIR%%/sip.so %%PYTHON_SITELIBDIR%%/sipconfig.py %%PYTHON_SITELIBDIR%%/sipconfig.pyc +%%PYTHON_SITELIBDIR%%/sipconfig.pyo
After talking to Eugene he agreed to let me become maintainer for this port. Would the committer please s/eugos@gmx.net/danny@ricin.com/ ? Thanks. See also ports/72154 (x11-toolkits/py-qt)
State Changed From-To: open->feedback Do any of the dependencies of this port (or, for that matter, the related py-qt) need to be reinstalled for this updated version (i.e. need a PORTVERSION bump?) It does not seem that the shared libraries that are installed have a version number, but I suppose it's safer to check first. (Also note, your mailer tends to strip tabs when you are doing followups, which makes life harder for us port committers.)
State Changed From-To: feedback->closed Committed, thanks!