Bug 72346 - [PATCH] net/mpd doesn't pass COPTS to make
Summary: [PATCH] net/mpd doesn't pass COPTS to make
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Archie Cobbs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-05 08:40 UTC by Oleg Sharoiko
Modified: 2004-11-05 04:19 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (622 bytes, patch)
2004-10-05 08:40 UTC, Oleg Sharoiko 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sharoiko 2004-10-05 08:40:23 UTC 
	Makefile of net/mpd has a line:

	MAKE_ENV=	COPTS+=-I${OPENSSLINC} LDADD+=-L${OPENSSLLIB}

	This creates environment variables 'COPTS+' and 'LDADD+', what is not what
	really needed, because ${MAKE} which builds mpd uses COPTS and LDADD, but
	not those with plus. This, in particular, breaks builds when openssl is
	installed from ports. I propose the following solution:

	MAKE_ENV=	COPTS="${COPTS} -I${OPENSSLINC}" LDADD="${LDADD} -L${OPENSSLLIB}"

	Besides, bsd.port.mk doesn't allow auto detection of openssl
	when it's installed from ports, where combination of bsd.port.pre.mk
	and bsd.port.post.mk do.

Fix: Please note that this patch shouldn't break current behavior as
	bsd.openssl.mk handles WITH_OPENSS_(BASE|PORT) and sets OPENSSLINC and
	OPENSSLLIB correctly.
How-To-Repeat: 	build and install base system without openssl
	cd /usr/ports/net/mpd
	make
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-10-08 06:05:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->archie

Over to maintainer.
Comment 2 Archie Cobbs freebsd_committer freebsd_triage 2004-11-05 04:19:08 UTC 
State Changed
From-To: open->closed

Patch applied, thanks.