Bug 72726 - update biology/ncbi-toolkit to 2004.06.16
Summary: update biology/ncbi-toolkit to 2004.06.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-15 09:20 UTC by Choe, Cheng-Dae
Modified: 2004-11-01 22:23 UTC (History)
0 users

See Also:

Attachments
file.diff (190 bytes, patch)
2004-10-15 09:20 UTC, Choe, Cheng-Dae 		no flags Details | Diff
file.diff (27.99 KB, patch)
2004-10-15 09:20 UTC, Choe, Cheng-Dae 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Choe, Cheng-Dae 2004-10-15 09:20:25 UTC 
      update biology/ncbi-toolkit ports to 2004.06.16

Fix: PORTNAME=      ncbi-toolkit
-PORTVERSION=   2003.04.21
+PORTVERSION=   2004.06.16
CATEGORIES=    biology
MASTER_SITES=  ftp://ftp.ncbi.nih.gov/toolbox/ncbi_tools/old/${PORTVERSION:S/.//g}/
DISTNAME=      ncbi
@@ -22,7 +22,7 @@

DUMMYMAKE=     Makefile
DOCDIR=                ${PREFIX}/share/doc/${PORTNAME}
-CPIO=          cpio --quiet -pdum -R
+CPIO=          ${CPIO} --quiet -pdum -R

#
# Thus ends the definitions.
@@ -36,8 +36,8 @@

post-install:
       @${MKDIR} ${DATADIR}
-       @for file in ${WRKSRC}/data/*; do \
-               ${INSTALL_DATA} $$file ${DATADIR}; \
+       @for f in ${WRKSRC}/data/*; do \
+               ${INSTALL_DATA} ${f} ${DATADIR}; \
       done
.if !defined(NOPORTDOCS)
       @${MKDIR} ${DOCDIR}
How-To-Repeat:       N/A
Comment 1 Sergei Kolobov freebsd_committer freebsd_triage 2004-10-15 09:20:47 UTC 
On 2004-10-15 at 08:17 +0000, Choe, Cheng-Dae wrote:
> >Originator:     "Choe, Cheng-Dae"

It worked this time! Thanks for doing this.

Sergei
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-10-15 16:23:54 UTC 
Dear maintainer of FreeBSD port biology/ncbi-toolkit, please take a look
at 

http://www.freebsd.org/cgi/query-pr.cgi?q=72726

Do you approve this update?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

It's now using GIFs instead of JPEGs. This is similar to replacing
triangular wheels with round ones.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-10-15 16:24:02 UTC 
State Changed
From-To: open->feedback

Asked maintainer for approval.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-10-15 16:24:02 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

Handle.
Comment 5 Choe, Cheng-Dae 2004-10-27 16:56:23 UTC 
I think wjv was timeouted by his business.

see
- http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/68950
- http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/71400
- http://groups.google.com/groups?q=3Dwjv%40FreeBSD.org&hl=3Dko&lr=3D&clien=
t=3Dfirefox-a&selm=3Dfa.g7utvj1.1d30995%40ifi.uio.no&rnum=3D4

I was mailed wjv in last week. But he was not reply.=20
--=20
Choe, Cheng-Dae(=EC=B5=9C=EC=A0=95=EB=8C=80)
Blog: http://www.comdongin.com/
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-01 22:21:06 UTC 
State Changed
From-To: feedback->closed

Well, the PR was crap. 

What you submitted had zero chance of working. You basically 
only changed PORTVERSION and then everything was bad. 

- CPIO line change bad - it creates recursive variable 
- post-install change bad - ${f} is not expanded by subshell 
- not updated distinfo 
- only half-done update of plist 
- @dirrm %%PORTDOCS%%%%DOCSDIR%% -> %%PORTDOCS%%@dirrm %%DOCSDIR%% 
Do you even have idea what these substitutions stand for? 
- files under files/ were not updated where needed 

Basically, I did the whole update from scratch. 

Oh, and the patch file was mangled, leading whitespace stripped 
and all tabs converted to spaces. 

I hope next time it will be more quality PR. See you later.