Bug 73259 - Update port: textproc/xalan-c update to 1.8.0
Summary: Update port: textproc/xalan-c update to 1.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Volker Stolz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-29 01:10 UTC by Douglas Thrift
Modified: 2005-01-17 17:46 UTC (History)
0 users

See Also:


Attachments
file.diff (19.78 KB, patch)
2004-10-29 01:10 UTC, Douglas Thrift
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Thrift 2004-10-29 01:10:25 UTC
Updated Xalan C++ to 1.8.0 and fixed to work with Xerces C++ 2.6.0.
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-10-29 10:20:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vs

I'll handle this
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-10-29 14:29:51 UTC
There's something wrong with the permissions of the installed includes:

ThreadSafe@menelaos [15:26:23]> ls -l /usr/local/include/xalanc/Include/
total 72
-rw-------  1 root  wheel   2547 Oct 29 15:23 AIXDefinitions.hpp
-rw-------  1 root  wheel   1941 Oct 29 15:23 CygwinDefinitions.hpp

Could you please look into this?

Volker
Comment 3 Bjoern A. Zeeb 2004-10-29 15:39:44 UTC
On Fri, 29 Oct 2004, Volker Stolz wrote:

Hi Volker, Hi Douglas,

first of all many thanks for taking the time to update the port. I
don't have much of this atm :(

> There's something wrong with the permissions of the installed includes:
>
> ThreadSafe@menelaos [15:26:23]> ls -l /usr/local/include/xalanc/Include/
> total 72
> -rw-------  1 root  wheel   2547 Oct 29 15:23 AIXDefinitions.hpp
> -rw-------  1 root  wheel   1941 Oct 29 15:23 CygwinDefinitions.hpp
>
> Could you please look into this?

There had always been problmes with permissions in almost all apache
xml projects I know *argl*. I had fixed some of them in last install
(see files/patch-ad I think it had been). The other question would be
if we really need to install these. I had up to now. Perhaps I will
remove this with my next update.


Apart from the above  the patch from the PR looks almost good to me;
only seen one thing while skipping through:

+-	${EXTRA_LINK_OPTIONS}  $(XERCES_LIB) $^ -o $@ $(LOC_OTHER_LINK_PARAMETERS)
++	${EXTRA_LINK_OPTIONS}  $(XERCES_LIB) $^ -o $@ $(LOC_OTHER_LINK_PARAMETERS) \
++	-pthread
      ^^^^^^^^^^^^^

I think this is not too good; Kris will mark the port
FORBIDDEN again because it does not respect PTHREAD_* I guess.
Please make sure to not hard code threading related things again.


The other thing is that there will be a release of xalan-c 1.9 in
about 2 weeks.

If you want this update to be comitted please handle this with
Volker. If everything is fine you have my ok.

-- 
Greetings
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
Comment 4 Volker Stolz freebsd_committer freebsd_triage 2004-11-04 10:13:22 UTC
State Changed
From-To: open->feedback

Patch incomplete
Comment 5 Volker Stolz freebsd_committer freebsd_triage 2005-01-17 17:46:02 UTC
State Changed
From-To: feedback->closed

Committed with modifications as discussed with maintainer. 
Thanks for everybodies cooperation & patience!