Bug 73371 - Update port: games/frozenbubble (Fix problem report ports/67355)
Summary: Update port: games/frozenbubble (Fix problem report ports/67355)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-01 06:30 UTC by Nicholas Kirby
Modified: 2004-11-05 00:20 UTC (History)
0 users

See Also:


Attachments
file.shar (21.55 KB, text/plain)
2004-11-01 06:30 UTC, Nicholas Kirby
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Kirby 2004-11-01 06:30:27 UTC
This is an update to the games/frozenbubble port to solve the PR found here http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/67355 . There are no chances besides the addition of the patch altered to work with the port build. Causes minor oddities (image on highscore section out of place), but does not effect gameplay.

I have no intention of taking over as port maintainer unless the current maintainer has no interest in continuing his fine work on it.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-01 22:29:27 UTC
State Changed
From-To: open->feedback

Thank you but two things - 

- please resubmit this update as a unified diff between old 
and new port directory. For details please consult Handbook at 
http://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html 

- most importantly, fix your mailer so it does not convert tabs to spaces! 


Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-01 22:29:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Look after.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-02 23:14:26 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-04 08:57:20 UTC
The patch from your PR is identical to patch from ports/67355 and in
audit trail of ports/67355 it was confirmed working by
<supraexpress@globaleyes.net>.

If you're working on even better patch, it will be welcome once you have
it done.

I don't feel we have to backout the yesterday commit. Opinions?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Time flies like an arrow. Fruit flies like a banana.
Comment 5 Nicholas Kirby 2004-11-05 00:18:06 UTC
My sincerest apologies... but PR ports/73372 was submitted after PR
ports/73371 and before I sent my unified diff file to Pav Lucistnik.

The other PR resulted when I tried to submit feedback to ports/73371
without a POP3 mail client (rather, my Gmail webmail account).

The unified diff that was commited works perfectly.

And as for the maintainer, I shall contact him immediately, and
apologize for not doing so prior to applying the patch to the port. I
wasn't aware that I had to deal with the maintainer prior to
submission (rather, that the maintainer would be contacted by ports
prior to the change actually being commited).

- Nicholas Kirby