Bug 73972 - [patch] sysutils/rdiff-backup: exception raised on EDEADLK
Summary: [patch] sysutils/rdiff-backup: exception raised on EDEADLK
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-15 15:40 UTC by Charles Ulrich
Modified: 2004-12-14 16:07 UTC (History)
0 users

See Also:


Attachments
file.diff (428 bytes, patch)
2004-11-15 15:40 UTC, Charles Ulrich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Ulrich 2004-11-15 15:40:25 UTC
In rdiff-backup's robust.py module, there is a function called catch_error which attempts to "step over" certain operating system errors that should not be fatal to the backup as a whole. In this, EDEADLOCK is listed, but not its BSD equivalent, EDEADLK.

Fix: To fix this, add the EDEADLK error to catch_error in robust.py. EDEADLK could replace EDEADLOCK in the list as FreeBSD doesn't use the latter (that I can tell), but perhaps the patch will make it upstream. I believe tabs have been preserved properly. If not, it's a two-liner anyway. Thanks for your time.
How-To-Repeat: Mount an SMB share via smbfs and use rdiff-backup to back up a directory containing a file that is opened on a Windows machine. Outlook .pst files are the best candidates. rdiff-backup will raise an exception, '[Errno 11] Resource deadlock avoided' upon encountering the file and halt the backup.
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-11-18 16:48:49 UTC
Dear maintainer, please look into this issue. Also, the web-site has moved  
(update pkg-descr).

Cheers,
   Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-11-18 16:48:59 UTC
State Changed
From-To: open->feedback

Forwarded PR to maintainer
Comment 3 Volker Stolz freebsd_committer freebsd_triage 2004-12-14 16:07:09 UTC
State Changed
From-To: feedback->closed

Committed, thanks!