Bug 74128 - audio/xmp incorrectly marked as broken for FreeBSD > 5
Summary: audio/xmp incorrectly marked as broken for FreeBSD > 5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-19 20:50 UTC by ringworm
Modified: 2004-11-21 14:54 UTC (History)
0 users

See Also:


Attachments
Makefile.diff (377 bytes, patch)
2004-11-19 20:50 UTC, ringworm
no flags Details | Diff
xmp.diff (1.23 KB, patch)
2004-11-21 08:55 UTC, ringworm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ringworm 2004-11-19 20:50:19 UTC
	audio/xmp marked as broken .if ${OSVERSION} >= 503000
	It compiles just fine and installs fine on my 5.3 i386 system

How-To-Repeat: 	try to build on OSVERSION > 5
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-21 03:30:48 UTC
State Changed
From-To: open->feedback

Looks like it does not build when esound is enabled: 

http://pointyhat.freebsd.org/errorlogs/i386-6-full/xmp-esound-2.0.4_2.log 

cc -oxmp  getopt.o getopt1.o options.o main.o -L../../lib -lxmp -lm  
../../lib/libxmp.a(esd.o)(.text+0x72): In function `init': 
: undefined reference to `esd_play_stream' 
gmake[2]: *** [xmp] Error 1 

Obviously -lesound is missing on that linker line... 
maybe you could provide a fix for this? 


Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-21 03:30:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Poke.
Comment 3 ringworm 2004-11-21 08:55:48 UTC
forget my original pr.  The attached diff includes a patch to fix:

cc -oxmp  getopt.o getopt1.o options.o main.o -L../../lib -lxmp -lm  
../../lib/libxmp.a(esd.o)(.text+0x72): In function `init': 
: undefined reference to `esd_play_stream' 

 and bumps the revision number:

new patch:

patch-src::main::Makefile

-Mike
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-21 14:38:50 UTC
Michael C. Shultz pí¹e v ne 21. 11. 2004 v 00:55 -0800:
> forget my original pr.  The attached diff includes a patch to fix:
> 
> cc -oxmp  getopt.o getopt1.o options.o main.o -L../../lib -lxmp -lm  
> ../../lib/libxmp.a(esd.o)(.text+0x72): In function `init': 
> : undefined reference to `esd_play_stream' 
> 
>  and bumps the revision number:
> 
> new patch:
> 
> patch-src::main::Makefile


Incorrect fix. This would add -lesd even when there's no esound on
system and esound is disabled in configure script.

I'm committing proper fix now (in fact, there's a botched local
modification in our port that breaks it).

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

You have acquired a scroll entitled 'irk gleknow mizk' (n).
This is an IBM Manual scroll.
You are permanently confused.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2004-11-21 14:54:22 UTC
State Changed
From-To: feedback->closed

Patched in CVS.