Bug 74237 - databases/mysql-navigator needs to pass a new parameter to mysql_shutdown when compiling against versions of MySQL greater than 4.1.3.
Summary: databases/mysql-navigator needs to pass a new parameter to mysql_shutdown whe...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-22 13:20 UTC by Michael Hambly
Modified: 2004-12-31 12:08 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hambly 2004-11-22 13:20:13 UTC 
Compilation Error: In MySQL version 4.1.3 the format of the mysql_shutdown function changed. It now takes an extra argument to define the shutdown level. The MySQL Navigator code needs to check the MySQL version, and apply a default shutdown level argument when compiling against newer versions of MySQL.

Fix: 

+#if  ( MYSQL_VERSION_ID >= 40103 && MYSQL_VERSION_ID < 50000 ) || ( MYSQL_VERSION_ID >= 50001 )
+       if(mysql_shutdown(&mysql, SHUTDOWN_DEFAULT))
+#else
        if(mysql_shutdown(&mysql))
+#endif
        {
                QMessageBox::critical(this, tr("MySQL Navigator"), QString::fromLocal8Bit(mysql_error(&mysql)));
        }--5tS2O7LM3Ym8AE0mhuDbMlYHDoS14Jl27N3e0jC4HiCrho6x
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- src/mysql/mainwindow/mainwindowslotshutdown.cxx.orig        Mon Mar  4 21:13:22 2002
+++ src/mysql/mainwindow/mainwindowslotshutdown.cxx             Sun Nov 21 17:08:38 2004
@@ -9,7 +9,11 @@
        if(z == 1)
                return;
How-To-Repeat: cd /usr/ports/databases/mysql41-server
make install clean
cd /usr/ports/databases/mysql-navigator
make install clean
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-11-23 01:16:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->demon

Over to maintainer.
Comment 2 Dmitry Sivachenko freebsd_committer freebsd_triage 2004-12-31 12:07:56 UTC 
State Changed
From-To: open->closed

Patch committed, thanks!