Bug 75100 - [PATCH] textproc/sgmltools-lite: [fix broken pkg-plist]
Summary: [PATCH] textproc/sgmltools-lite: [fix broken pkg-plist]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-15 10:50 UTC by darth
Modified: 2005-02-10 07:57 UTC (History)
0 users

See Also:


Attachments
sgmltools-lite-3.0.3_2.patch (1.16 KB, patch)
2004-12-15 10:50 UTC, darth
no flags Details | Diff
sgmltools-plist.patch (2.28 KB, patch)
2005-02-03 10:03 UTC, Stefan Walter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description darth 2004-12-15 10:50:17 UTC
LOCALBASE was used for installing the datadir, that will make 'port test'
validation fail. See fix.

Generated with FreeBSD Port Tools 0.63

Fix: Use PREFIX instead of LOCALBASE for installation, 'port test' works without
complaining after this.
pkg-plist seems to be fine, no need to change.
Comment 1 Kris Kennaway 2004-12-28 08:41:41 UTC
On Wed, Dec 15, 2004 at 11:49:52AM +0100, Chris Larsen wrote:

> >How-To-Repeat:
> >Fix:
> Use PREFIX instead of LOCALBASE for installation, 'port test' works without
> complaining after this.
> pkg-plist seems to be fine, no need to change.

While this change is technically correct (PREFIX is where this port is
to be installed), I cannot see how it fixes the plist errors, because
both PREFIX and LOCALBASE point to /usr/local by default.

Kris
Comment 2 Kris Kennaway freebsd_committer freebsd_triage 2004-12-28 08:41:50 UTC
State Changed
From-To: open->feedback

Feedback requested
Comment 3 Stefan Walter 2005-02-03 10:03:48 UTC
Hi,

I guess the reason why this port is broken is that it creates a couple of
directories it doesn't remove when it's deinstalled. The attached patch
should fix that. Other changes are:

- Use PREFIX instead of LOCALBASE as in the patch the originator sent.
- Use USE_PYTHON_BUILD instead of an explicit dependency line.
- Replace the URL mentioned in pkg-descr with the actual project
  homepage's URL (http://www.sgmltools.org/ says that domain is for sale.
  I think that's a good reason to let textproc/sgmltools die, then, and
  only keep sgmltools-lite around, which is that project's successor.)
- Bump PORTREVISION.

Stefan
Comment 4 Sergey Matveychuk freebsd_committer freebsd_triage 2005-02-10 07:57:36 UTC
State Changed
From-To: feedback->closed

Committed, thanks!