ngspice is being built without readline support to avoid possible licensing issues: ngspice license is GPL-incompatible. The GPL only applies to distribution though, so I suggest to enable it when we are not PACKAGE_BUILDING. Also, when we are package building we shouldn't build-in debugging support. How-To-Repeat: My enhancements are pretty minimalistic. JFYI, the ngspice team also added xspice and cider but they consider it experimental so they don't build it. They don't build X support either.
Dear maintainer of FreeBSD port cad/ngspice_rework, please review a patch at http://www.freebsd.org/cgi/query-pr.cgi?q=75504 Do you approve or reject this change? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> A spoonful of curry, garlic and mustard helps the medicine go down... and come straight back up again. -- JLE on #angband
State Changed From-To: open->feedback Asked maintainer for review.
Responsible Changed From-To: freebsd-ports-bugs->pav Handle.
Hi; The patch is trivial (and smaller than what I suggested to the maintainer), but according to portlint I added a space at the end of a line. Just letting you know so that this doesn't go in unnoticed :). __________________________________ Do you Yahoo!? Send holiday email and support a worthy cause. Do good. http://celebrity.mail.yahoo.com
At Tue, 28 Dec 2004 04:36:35 +0100, Pav Lucistnik wrote: > > Dear maintainer of FreeBSD port cad/ngspice_rework, please review a > patch at > > http://www.freebsd.org/cgi/query-pr.cgi?q=75504 > > Do you approve or reject this change? Pav I'll have a look. Thank you. shuhei
At Tue, 28 Dec 2004 04:36:35 +0100, Pav Lucistnik wrote: > > Dear maintainer of FreeBSD port cad/ngspice_rework, please review a > patch at > > http://www.freebsd.org/cgi/query-pr.cgi?q=75504 > > Do you approve or reject this change? yes. Looks ok to me. shuhei
State Changed From-To: feedback->closed Committed, thanks!