Bug 76753 - [ patch ] x11-wm/fluxbox-devel: utilize OPTIONS, some new knobs, portlint
Summary: [ patch ] x11-wm/fluxbox-devel: utilize OPTIONS, some new knobs, portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jeremy Messenger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-27 14:30 UTC by Roman Bogorodskiy
Modified: 2005-01-28 03:06 UTC (History)
1 user (show)

See Also:

Attachments
port.fluxbox-devel.diff (3.18 KB, patch)
2005-01-27 14:30 UTC, Roman Bogorodskiy 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bogorodskiy 2005-01-27 14:30:12 UTC 
	- x11-wm/fluxbox-devel has lots of build options now,
          so I think OPTIONS utilization will be useful
        - add XRENDER and REMEMBER knobs
        - replace DISTFILES with DISTNAME to avoid portlint warning
        - bump PORTREVISION
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2005-01-27 21:15:54 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mezz

Over to maintainer.
Comment 2 Jeremy Messenger freebsd_committer freebsd_triage 2005-01-27 21:29:12 UTC 
State Changed
From-To: open->feedback

Sorry, I will never accept any of patch that change to use OPTIONS in single 
of port that I maintain. But, I am going to take the look at your patch by 
add few more new knobs. I always will accept to add more knobs by user's 
request. 

I can't replace DISTFILES with DISTNAME, because of WITH_DOCHTML and 
WITH_DOCPDF. If I replace this and this port will not work correct. 

I disagree for enable IMLIB2 by default, which it is disable by default in 
the fluxbox. I rather to follow fluxbox's foot. 

I am not going to bump PORTREVISION, because it is not need. 

Thanks for patch!
Comment 3 Jeremy Messenger freebsd_committer freebsd_triage 2005-01-28 03:05:50 UTC 
State Changed
From-To: feedback->closed

I only add two new defines, WITHOUT_REMEMBER and WITHOUT_XRENDER. Committed, 
thanks!