Bug 77795 - [ update ] audio/bmp-songchange: update to 0.0.2
Summary: [ update ] audio/bmp-songchange: update to 0.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Johnson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-20 19:10 UTC by Roman Bogorodskiy
Modified: 2005-02-22 19:02 UTC (History)
1 user (show)

See Also:


Attachments
bmp-songchange.diff (1.07 KB, patch)
2005-02-20 19:10 UTC, Roman Bogorodskiy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bogorodskiy 2005-02-20 19:10:16 UTC
	- update to 0.0.2
	- DISTNAME is not needed anymore since distfile was renamed
	- remove USE_GNOME=gtk20 since dependency on beep implies that
	- use USE_LIBTOOL_VER=13 because of some weird problems with 15
Comment 1 Michael Johnson freebsd_committer freebsd_triage 2005-02-21 08:37:41 UTC
State Changed
From-To: open->closed

Commited, Thanks 

I left USE_LIBTOOL_VER=15 because I didn't have any problems on 5.x or 4.x building. If you have further problems out of libtool15 you may wish to reinstall devel/libtool15 if you changed CC/CXX since you last installed/updated libtool15.
Comment 2 Michael Johnson freebsd_committer freebsd_triage 2005-02-21 18:19:57 UTC
State Changed
From-To: closed->open

Re-open, not really committed 


Comment 3 Michael Johnson freebsd_committer freebsd_triage 2005-02-21 18:19:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ahze

Re-open, not really committed
Comment 4 Michael Johnson freebsd_committer freebsd_triage 2005-02-21 18:43:39 UTC
Please see http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/77795
do you approve this patch?

Michael
Comment 5 Miguel Mendez 2005-02-21 20:40:38 UTC
On Mon, 21 Feb 2005 13:43:39 -0500
Michael Johnson <ahze@FreeBSD.org> wrote:

> Please see http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/77795
> do you approve this patch?

Looks fine to me. The only question I have, and it's not really specific
to this port is wrt implied dependencies. If it's okay to remove the 
gtk20 dep as beep depends on it then it's good to go.

Roman, since you're the author of this plugin, feel free to take 
maintainership if you wish. Else I'll take care of it.

Cheers,
-- 
Miguel Mendez <flynn@energyhq.es.eu.org>
http://www.energyhq.es.eu.org
PGP Key: 0xDC8514F1
Comment 6 Michael Johnson 2005-02-21 22:46:10 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Feb 21, 2005, at 3:40 PM, Miguel Mendez wrote:

> On Mon, 21 Feb 2005 13:43:39 -0500
> Michael Johnson <ahze@FreeBSD.org> wrote:
>
>> Please see http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/77795
>> do you approve this patch?
>
> Looks fine to me. The only question I have, and it's not really 
> specific
> to this port is wrt implied dependencies. If it's okay to remove the
> gtk20 dep as beep depends on it then it's good to go.
>
> Roman, since you're the author of this plugin, feel free to take
> maintainership if you wish. Else I'll take care of it.

Roman,
do you want to take maintainer ?

I'll wait to commit until i hear from you.

Michael

>
> Cheers,
> -- 
> Miguel Mendez <flynn@energyhq.es.eu.org>
> http://www.energyhq.es.eu.org
> PGP Key: 0xDC8514F1
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iD8DBQFCGmSzn4uqfTwEb9YRAqzcAJ9GZH6bUOET4TaPHtBsRqkzIxZW9wCffHhS
o9DQy+Go9fS9T2QDR7HO85k=
=oMuM
-----END PGP SIGNATURE-----
Comment 7 Roman Bogorodskiy 2005-02-22 17:27:06 UTC
 Michael wrote:

> >Roman, since you're the author of this plugin, feel free to take
> >maintainership if you wish. Else I'll take care of it.
> 
> Roman,
> do you want to take maintainer ?
> 
> I'll wait to commit until i hear from you.


It doesn't really matter for me who will maintain it. Do it as Miguel
wants. :)

-Roman Bogorodskiy
Comment 8 Michael Johnson freebsd_committer freebsd_triage 2005-02-22 19:02:03 UTC
State Changed
From-To: open->closed

(really) Committed, Thanks!