Bug 78686 - Minor update to the BRLCAD port
Summary: Minor update to the BRLCAD port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Simon Barner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-11 05:50 UTC by giffunip
Modified: 2005-04-01 20:37 UTC (History)
0 users

See Also:

Attachments
file.diff (984 bytes, patch)
2005-03-11 05:50 UTC, giffunip 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description giffunip 2005-03-11 05:50:02 UTC 
      Kay Lehman has suggested sending environment variables to mged so I added that, and there was also a small typo in a header file. The changes are pretty minor but I thought it good to have this before the freeze.

Fix: Please apply patch:
Comment 1 Simon Barner freebsd_committer freebsd_triage 2005-03-11 12:06:00 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->barner

Grab.
Comment 2 Simon Barner freebsd_committer freebsd_triage 2005-03-11 12:27:03 UTC 
> diff -ruN brlcad.orig/files/mged.sh brlcad/files/mged.sh
> --- brlcad.orig/files/mged.sh	Sun Feb 20 22:00:46 2005
> +++ brlcad/files/mged.sh	Fri Mar 11 00:34:52 2005
> @@ -8,4 +8,4 @@
>  export PATH=%%BRLCAD_ROOT%%/bin:$PATH
>  export MANPATH=%%BRLCAD_ROOT%%/man:$MANPATH
>  
> -exec %%BRLCAD_ROOT%%/bin/mged
> +exec %%BRLCAD_ROOT%%/bin/mged $1 $2

Hi Pedro,

what do you think of using the following patch instead (i.e. pass all
arguments to bin/mged)?

-exec %%BRLCAD_ROOT%%/bin/mged
+exec %%BRLCAD_ROOT%%/bin/mged $@

Otherwise, it looks fine!

Simon
Comment 3 Pedro F. Giffuni 2005-03-11 14:11:56 UTC 
Yes,

I'm not a used to /bin/sh programming but it does make sense, thanks for the
suggestion.

    Pedro.

--- Simon Barner <barner@FreeBSD.org> wrote:
> > diff -ruN brlcad.orig/files/mged.sh brlcad/files/mged.sh
> > --- brlcad.orig/files/mged.sh	Sun Feb 20 22:00:46 2005
> > +++ brlcad/files/mged.sh	Fri Mar 11 00:34:52 2005
> > @@ -8,4 +8,4 @@
> >  export PATH=%%BRLCAD_ROOT%%/bin:$PATH
> >  export MANPATH=%%BRLCAD_ROOT%%/man:$MANPATH
> >  
> > -exec %%BRLCAD_ROOT%%/bin/mged
> > +exec %%BRLCAD_ROOT%%/bin/mged $1 $2
> 
> Hi Pedro,
> 
> what do you think of using the following patch instead (i.e. pass all
> arguments to bin/mged)?
> 
> -exec %%BRLCAD_ROOT%%/bin/mged
> +exec %%BRLCAD_ROOT%%/bin/mged $@
> 
> Otherwise, it looks fine!
> 
> Simon
> 


		
__________________________________ 
Do you Yahoo!? 
Yahoo! Small Business - Try our new resources site!
http://smallbusiness.yahoo.com/resources/
Comment 4 Pedro F. Giffuni 2005-03-14 19:13:24 UTC 
While here:

Please mark this port BROKEN on SPARC64. I reported this bug upstream but I
don't know how to fix this.

thanks,

   Pedro.

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com
Comment 5 Simon Barner freebsd_committer freebsd_triage 2005-04-01 20:36:09 UTC 
State Changed
From-To: open->closed

Finally comitted, thanks! (Marked IGNORE on ARCH != i386).