Here's an upgrade from Flyspray 0.9.5 to 0.9.7. Lots of new features, and prettier too!
State Changed From-To: open->feedback Please submit patches in unified diff-format!
> Please submit patches in unified diff-format! See attached file. I submitted the patch as a shar because the diff was bigger. Nick begin 644 flyspray.diff.gz M'XL("$:$7D("`V9L>7-P<F%Y+F1I9F8`K5UM<]LXDOYL5>U_0#Q).2Z:>K-D M)YK+311;27SCM[*<S<[=7+DH$I084227(.UX,OGOVPV0%"43!*0DZ_'*XM.- M!O!TH[NI%\=S76+&Z25Q_4<6Q=:CV6Z^;O9;%]:<NIY/B^>+9QJF:<K0.^]C MCPS3*>FV2;<SZ!T/VAUXW.XU#,-XJFKG=I:281233H]T^H/^(?P@O-]X^Y:8 M1P?'Q,!?;]\VR"\-TB#75S>WE\.+T9N=7%7#Q.?^.;H9GUU=OMGAUC2,)\\= M-\C)\';TX>KF;#1^L^/0>^HWR,5P?#NZN1N?W>*3LR2)!JU6KKD9A_:<-6V[ MA9:R%HR/1G7Z!T?$@-_"K`:Y^71Y=SJZ'EV>@H[GW\ZO3H;G[X;CT?<6FUDQ M;5E.Z$S$[Z87V,UH%@V>?T,+QZ=G-]];CI58$XO!"!P#*HU/X]'=S>CL\OI\ M>`)S?:2L0?"YZX_7;W86C^S?/HGLF!(08EX8-,CGX>4M7KW[/'J7X;FQW>[! M*V)T#P^ZW<S:TW<PZ)N=G=:]%;?X:.;IU<G=^[-S7(+AI]N/5S=C\N[3AS$Y M^3B\_#`ZO_I`3JZN_SB[_$#.+L>WP_-S<C,:GEZ,R.W5Z17Y=/WA9GB*5\&L M8O%,,<-L#[XWN=$-\_WY'^/KF^$?^7BN=>_98="$7\1-`SN!V;!\E4K/?&'$ M"QSZE3_M6\&4,#OVHH219$87E)&83NG7B%]&,])H&EL.O<.M[]TE(7_0-[D5 M"&H83R?=3+XF?.+\03%Y_E<V<?Y83)X__+-A[.S@*O"_BI4HP]['E+X;GPJH M[]DTL&&GAZ=7P(;LSZ6JXOK[G(-RR&5Z'_K6F8W+(T=]82>63P/'BFM`L"`7 M5CQWPH>@C&H8#:-NPV84ECCF:PX[YJ<.E>X2,E;L%"J-0I:8D978LP'8\?S; MR?5W`GSY_0/W!^%M:\OW_-OGF]_'-R?@+J$-OHABA8?<G5R<?B<F);OL[Q<O M"@=\\>)OT'HS>G_VK\P7_Y[^NBOFOM2'=/$"EEB^SV/9L>`'ZK_X3A2XYL2: M:RELAK$W1?]S0C.[.&@0D+KX'2=-U@QM"??!4/>=._+A$4:=?B>+.F5![M'? MRQ(M*TDL>[:@0<(X]N3CQ16LT'&_K8N_^GSYG3P\/`S@/[6,424CGQ`L`Z=` MOA`D7R[86QC_+2@;WF:4N!B-Q\,/V2KT>OQ$:&>KT/1<\LR!@R2@SLO+*QP` MW'J\+W0L%PB>PX<@X(8QX8>:%X@+@M??&R9*9%Y^=SJ\'9:W_ODWE%E19=3A M.44KA$@3/!%,$`\\%Q;"D1V_CL<2+W##Y9F9/U-U_.;7-(_?`CZV$@*N3SI= M^!ET^X/NZ^7QVSGHPD%WP$\.\^*T3UZNCMI,(*I,_]HG;PAU)QW[Z-5QM^/V M#BW;.ISTCMO'1Y.^8W6/>[UNPQR?_>^H1D'GL'?4Z3:,I\,<EU#6Y.@5_*_7 MZW2MMCOI]5^W^T=M2@^/VI-)QX6#OV*8LH+#'EAS*%_URMA3+%O5U:K=J,+Q M3.=_K("0#FEW!NTV_)#.Z^/VZLY4BN*FXBYU^P3E7F>;*G:I?=#&73H^PFTR M3L+`]:9I;.&Y2<[`K^)4G*$$N9^?*PWCC=X_#-?M?7+FDL<P)>#(1!RM'@1W M-PX7Q")13.^],&7DGL:8C9#0+>9S0"*?0FY#V-R+2!(V#$+P(""?"BV,<OO( MA/KA0Q/'Z^R3DYA:"07E(MG)4Z25.8`ZDC+:).0C!;L\1L*`D@=QP0EA&"LY MX`-R0W'4-/"^MGPO2+\2.UPLK,`A\!<](!#%:(S6P"SC;-`X#!,268P]A+%# M'F8TX,HB4!8EU!F@J;\(K.4L(*"8J9`Q(V(+^XLD%:!=6,5%%,8)MZ281#$U M^#^?'Z!@/;<BH`^$PE!+3#.?:;&,D@F1!4UFH?,K+"IA*8B`3C[%]?F)&97G M6#F_\M3R.9'_6M(^V_DFYG@@=;B/S*/95-W0AYW%Q;57R)D;O)PQ)N!.$U%\ M\)VA[UF,[!9)96L7_DA9W/)#V_*S@V5Y$65Z^^0Z!(U"X20.'\`.G'Z6W./3 M\`P8#.,LEL($+4&*LUF8^@Y?%T;IZEXQFJ11EM,\P]'ZM9X!GN`[9:]X7WA% MY@XD"($EG38?3C@`(5<P9OS@,:!E1B,8@%'?!7=`3L#C^(#;&Z6XPD!\?$JL M(\AR94/.R&D<IA'WJ:/]+*,EMQ]'Y'HX'G^^NCDE[Z]N^!,LC6C<XK_)\.3D MZM/E+9D\$ANRP3E.")=A[V0&*9U0?YU19@_I-@>S(#HA)@DCG"@^C*PI^N8? ML#@+;SI+`#GG1(3#!ZE>F&K9=IC"C@%!O9CZL#K@Y%Y"'CS?)U84H6Z8"^KT MX=Q"_0NZF,"RHC9@.-CB32$%$%YA,2C:<,K',&6T'\("%Q9.BO9R0=A,V#'! MDZM(A$CA/RP1"EZA@I`)$C!K$:'1H%XL_H1.09WE.$78P/09Y5[ODQO*/=T* M'LDDG3).$4A30,H"@Y9T?%IK_A:]&:<1EP[C8HT6EN?C.'P!<`K464:U@I^S M<$'YLJ,54$6N\O$ZC]/_%(QD94IJ'PC%J8`;:P/'LU*K[C0H#`1*.6'.IR(N M#+)#!LCND"?^#<G4TDU72JS\L.!KFF\ENEP1HG"WEA$V93CT+H]H3KJ(=H&> ME^$!CNL#[?A"\Q``1P',P'\D<2JH$WN@!R8";$`56`+SP5`U\40$<,)@+Q'G MCB?X`Q'?#V%*JM`#-"I'JP.2<S/?_6(&X"I0\8-KQ19$>/0`9"+W4F[G+L1. M2.Q2[F<!_9IP+]P%#B8)A&?"M4'-?GEUFTGMGE1+6'@NAZ`\\1:4O/2:X,N9 M'R&`*WJ8>?:,[QH$Z4N0/2`/E$?"J=AD6(N81\T$_\QWJ#C-FLW=_?RXD$91 MGE$=\*L\(`04J(\G?T:[%959V.;C<2='Z2-P5<@;2E:)K%#$)J1PMFE(3]RP MC*!<63Z,"/JP!)RLA/]3[.MZ'Z*?]R&.RGT(KNR/]=EEFW--8[!\45@1A`_/ M=IO9.7<K600B<CX\]HL5/,+,:0')?CY[P<Q\ELLC^M/->>E`SABY_9R/\CD? M:\SVUIICYH+/%!%#&,OGG1VXMY#6[4&>E#Q;^OD,TH0)I44P<LJ[G'%K`9X# M%TINQ>B_4^QUH&=GR0@K,0T2H0D<5*C]GJ+K)YF_9VX`(1M4BK"!;K@`0_(9 MQ30O;M?VAN^(6%N(6G`XB^5PO/STFF/6*ZY!9,*#\S=5N<([*6:I&[-63:Q? MEY<LZTC-<E(B+*UX1''9>44,+%ZPND2+EI*\6<+'?D\G.':[.^B]'J`1.+:) M@U<;"47L86_0[F5`W@(]Z!P2@__&D0C\M%KD%%(-.PDA/#UXR:R4XHF&59.< M(<EPGYTE<H;9-X\4HH?`A"X\K2!A;L(TGN,F@P24FGN\P_KP\%!XQ]ZO8/H* M0I;+(C(SM+`,<CQ&AJ=7I^]X%;1V)C0KW"ICH-`#"16#]$#,(<Q.'.'"3ZJJ MO.^*SI/P"#FAN39(LX2^@'G.6GZ\7*KL3(0L=M8$CZ7B:.&E"5J79V[HB5R; M'<8H"F<+;$8>?59:YGS)<8FS5N-=B)[[,BL(I)WV7;*/JUXI5%YYJ6BV#>0B M!"]\%+N_G`QW==='TW$E*J=1I%A"446;F\],R\DAO@X&3YJ+U9Y8C54Y?[74 M1MT+I2+>RP`?/1QT>X-N[TDOH]/AO0RT5-Y,+6OJ'`^Z1Q">A"8#;:H47)=Y M-6AG_2X#AS_&FSK&<79KQ\#MNL7]YEL]I>)N`PFA2+)X1L,>64(7X%>\UX#) MSQQ.JBPORAH16*,QWV(S7MMG"50R^P>HAW,:?EX2O&]S-3X@NY_/+G?WR6_D M.1>`"+'[YY^[9%#ZN[7[*TJ6@@@FKZCPY5ZSV=K;)\T,C3CS.2<T9^.;I5"3 M[/'G]PIP\53.R3T4-U;$]U8ZZQ6R*G4$_X/`\/*9!R=Q\O+YW7@TQKM#_[>7 M6;;W__O[Y-L_1*Y1=;DT"]`H]9AH/C4=FA_`!3M7GJ[R@Q6`N#6)Q\HKH,B@ M?S0XY&??X2KEG\HLV7T(G.POV=W%%C[>D!-WXFR,WL^[P(H&.1UEO61(B'_9 M:4V\H`5IG^D2>;NC*!VQ7R*RJT(2=UDNV2`[U)Z%9-<T=XO'M^5`#KD-Y%&+ M95[E4!_J#0<+"4YA*&HAM[=$<Z`XB@"^5!B$B9!-PM2>P?&(":O00W!;GJC! MAC3FJ!`;#PC]2NTTX2?$;OU&8UX'%<GJCF1/RC8YNZR9WJQ++%NQ$$-ZW7+# MO-_AO5AQPQKO6)NZ#5E3N_2^%AU57BWC(F;<$P-XY0$\J%;`A)_:3S5_6C/5 M7'8:S8:IVTD%Z$_MI)H_I8UJRGJHRYEMTD,%*2B*1XXGIEA.[3'QQ.Y5ZB7K M91]V)V'W1E]YJXIA-<T7^=[#BB@[?'BR49$L8LMA55_R&/&AX-3G:6?#9*(Q M!0(YZ&!-!AN1@04U'&]/9FLB^F5\(EA$\:2O9#5/0>,4^U%!V3++9V%AGEAV MW@/$;#MK+'%53]-$/IXDSR($/!)3UYC8V,_,NU%V&,X]T,8L/R'WEI]B7Q&. M=-]OXG;T?D)+&]1LW-(&F?Y/:FF;V,_.O>49(><A;V`RLL?[OGL'HA02&4K& MYNP27X*C(HQLUH]>[46#HN,?[D4WS*P9_3,:T2($_+PNM)FUH&&FKWZH!0T* M7F_3@@:Y3OM'>M"3A+7R[K.Y:>L91^_4=?3<<F^G5]PA!,ZL,[QA0JXM5N[3 MS3EWH`W[3]6O_=FI;S*OW>`E_"BOS4$BOC@K"0-_2I9_\(L;9!]+?"GW:`^Z MG7+NT3GBQ=-A3[S4:RV4E%^N8:ZGDLL7]3R]MAY&:Q!?6,-09JGKABT/-Q-? MEO!40\DX0RK[Y%+^BJ062Q[A,(30!DEH7&5B@5R^ADR.J9UL@?K"[.Q55RU\ M&50K_\N<AV::N*^V$W:][>3HEL8ZZ;:3W$Z.;3F_8,OQ9EO.C\VWDXNWM#/> MTD[+W7)=XA\@:>3_@+#-3,BJMF2YOZ7<EN--XNWD_.1'0L"6@P;^ME383NY+ MM"U[MI/SDFTW8SNYOV9;AHXMU\6VMES/+>?G;#E>LB5?V/V6=E)=.6\Q;4X] M5PN[-(LW>)LV8QO*\5)<TS+(R5(KAJ17V[Z$XNNG0^;QFS2S9.%O9)ZN8:50 MAW7%QJLP@2)Z<RDH;S87@E.C.S<[VPIVM05%V0FELQ::>5BQ@5W:>Y1)=#>6 M.-27$/7-9I2I38JE+G#'DMB#VMG9F')3*+XVI]S&XQ6^U]W(^39?#O2%[K;T MM$/?V9[<7%I_[)CR>MS$ER8R?5*)-WYHPR?IE$>QF><X-`"VX#U4U7!/:U$I M=)&_GZ46-?W+B^[L<!'%>`N]JCHMWL_RI.PM58OKE_@9Y>!-Y847U"/29(8= M)WP!02W0GF%/KA;BT,3R_'J,NIK/D?*)YP@?^X>3L!ZTL!0KL.#WU6LA`7T0 MS4,%*(K#+\`B%0S[9RH,-C!K,;#['N0&]2!&[VGL)?6S8XF5I#6[1H,2CX@, MH<4C`*IX!!`ECP"C]L0<&?,N)*O%K&RP;(I+0LK4K"QWS5@%`8P?GMT:ZPSU MJLNFM^)-,CU1[(7*&98()1NL\$KYKI7H;6@013J2PKW7=]_46VA38W>)'%/O MWNOS-W7X9JIWHQ+B)1H+`"!%/`:$VAPQ5GW\`XQ>,!'*E)L",,U#!Y#J(P5` MJA"&2Z%>]/J#"0!J"@!(&2MQ)(4+B(6LIR3N2G$(&,ICHA(1)9/XZ=[*H2NT ME,,4<9ECU)$Y'[$^-G.49G3.-2KC,P>JPR^'E;A7,]LE^^2@^A#,(>H@S&%E M#M8I`WID;^N6&[6D:NV:%F2M(5H]&?$7WE*3(UQ=LKJQ.LEP=>CL*LGLZE#9 MU2"RJTUC5X_$K@Z%736!`:).,EPUQUT=^KHJ-W`UV.VJ:>LJZ>AJT!H_H$.+ MD`!4DPU`JHR6Z62T3".C9=H9+=/+:)E.NLJ49.-W9^MYQ$OYVG./Z22K3,TC M'$G!([$\:I;4<ZVJ[#>D9:8BL*V7QX:RG#=TBE5#HWPVM'L,AE[-;N@T&F0@ M==1:[:(8ZG+<T*G]#57CP]!HUQCJYHBAT:PPE'VH2D3@:Q(2@$I"`D9-R,!7 M$1(0:D**L>H)"1A-0@IM2D("3$U(`*FX!A`U9W$9%(3DFZ(B)(#J"0D`)2%1 MB8*02"4EV=0)I"XAHU5"$@E&W5^*RH24(58(63-6?8%=-3F9LJ?,K1FVS%P9 M;(6Y,I"RR%ECKG2]%(VH:(VY,E#!7!E`V8B*?&45'JWR4J9&T=)_6CB;&H6S MJ5<XFUJ%LZE?^YNZ=;.Y03%NZM78IDZ-;>K4V*9>`6VJ2W%3IWHVM0IQ4Z?& M-K5J;%.CQE['9&]C5;:$-()Q54/0D/;,%-G!>K?34'8[#9UNIZ'1[32TNY.& M7KO34/<G#9T^IPRDS@Y6.YV&3B/34+5##8U.IZ'N=!K;=3'7>J'5">U<MWZ: MZ]1&<V5M-->IC>8:M=%<NS::Z]5&<W5%,]<IG^;JLF>N4_;,567/7*/LF:O+ MGKD>2Z2W38OPJ#H1<V#-F52"U)R8.:IN^CFF+HKFF%IB%XHD]QSSZW+BEX:1 M<KJ$J6-J]?K(3*HE:PYB]BRF"\4:UI"U:C-D!M4<UY5[8>JMDOD#"Z[F=5WZ MH+="\L^NB:;%^V@40J4/?Q$?_ULEL/91C7(@O]+-1J_7)=YLPN:T&E;Q::^* MF1PV._E<>N4W$NDO`+?[Z7[IO%UI?0/%Y^BVWODI?6QEG^P4!=-Z7,W+LU2? MV:-/C?J56=MIL2)&G=&)-<&7H5EP9-Y3/D=2!X]H;$,T!_W*Y<BAG;:^VDY; M@&M-7G@+VK*BR/?$NU1;H9W0Q&0)5!"++<2_FO@:M2T$(\?5E$KHUZ2%S-`= M)76\4!/K+?`]@1M;OX'EFE!\#[2.T31(6UF<CF+J,DV1(FQKH8L#7@LMW@VJ MA\4W(`-7-='4\9+%8W$*:LDP:L7V3!.,AQ"S`H<?C]KS#:=AJCN%4+QM5HW6 M7IFUT%`?H/"/RE?6KL`L9FL86+S46H5D"WPCNQ)6.AIJ<0[-S-.*@EV=98&X MO6G0/M31ZR7^!BI[&P3W_@;8HPVPQVW=C3)#?#>SMN)7&QCQ6N-$7-LS<[-S MV=3S$E-O=R6PSV$(D00*3(VL9XDM93Y*++Z#W9Q,]11SL*L+ULE-GL([&^,W M%.ANB#_<$-_;$-_?$'^T(?YX0_RK#?&O-?%*GRA!EW[QXD7^'0<OX%_VO0(O M7K2R;S"1`_!K3>17B^\ZJ8&(;X"1`[+/KY(#LG<=2:_CUZC(KQ8?_"N'K'VW M0'4EJ5L4K9[?Q6<GJ(.YR]\KQV&*W1*OQ:O;L7K$RC?4R&&EKZZ1@Y;?:2/' MY-]S(T>L?#ISS?S7O_Q&#JWZ'APY6O*5.'*!ZF_'D>.E7Y2C6-?BHT3*N+>. M%\<+4H(WC.PYS??!;H!701ND^GKVVF*9>'$OJA;@UE]6C.[0AEESV4MJE0=^ MK?+(KU6NG)IB=&=>-[ILZ')`46"*8Z(>)[,B:P9*+V,$5=M8Z@OHPWEK8`/M MR^Z`OA`V"/31O$>@#=<#0HVJ`ZS'2+8'MCP-\(,22?:)C^(KW2H_\X=T_QL< :Z;X5I+Y/_OZ;)'%*5?*5,O\!O)V4(C!P```` ` end
Responsible Changed From-To: freebsd-ports-bugs->leeym I will take care of this PR.
Hi, Some issues: - the version appears in the patch filename, so the filename is expected to be changed in the next release. I think we should use REINPLACE_CMD instead. - pkg-message is not PREFIX-clean. put %%PREFIX%% (%%DOCSDIR%% in this case) and replace it with the users's settings before installing will be better. -- Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
State Changed From-To: feedback->closed Committed, thanks.
Yen-Ming, thanks for committing this port. > - pkg-message is not PREFIX-clean. put %%PREFIX%% (%%DOCSDIR%% in this case) > and replace it with the users's settings before installing will be better. Good point. > - the version appears in the patch filename, so the filename is expected to > be changed in the next release. I think we should use REINPLACE_CMD instead. I've just had a look at what you committed, and it doesn't work properly. The problem here is that in sql/install-0.9.7.php, $basedir needs to be set to /usr/local/share/flyspray, but $adodbpath needs to be set to /usr/local/share/adodb. If you change $basedir to use ${PREFIX}/share instead of realpath('../'), you break includes for flyspray, and the system doesn't work (which is what's happening at the moment). The two variables need to be set independently. It's not a fatal problem, because the installation can be completed by filling in the correct values in the installation page. However, by default, flyspray will not work with your patch, and that's not good. I've fixed this problem in the patch below by changing the REINPLACE to modify $basedir. This means that the patch file is not needed. This patch also fixes another cosmetic buglet in the main flyspray distribution. I've also tidied up the Makefile a little by using ${FLYSPRAYDIR}. Can you take a look at it and commit if ok? thanks, Nick diff -ur --new-file flyspray-0.9.7/Makefile flyspray/Makefile --- flyspray-0.9.7/Makefile Tue May 3 16:54:58 2005 +++ flyspray/Makefile Thu May 5 17:27:09 2005 @@ -7,6 +7,7 @@ PORTNAME= flyspray PORTVERSION= 0.9.7 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= http://flyspray.rocks.cc/files/ @@ -18,10 +19,10 @@ USE_REINPLACE= yes USE_PHP= mysql pcre session WANT_PHP_WEB= yes - NO_BUILD= yes DBDIR= /var/db +FLYSPRAYDIR= ${PREFIX}/share/${PORTNAME} DOC_FILES= AUTHORS.txt BUGS.txt CHANGELOG.txt INSTALL.txt README.txt \ TODO.txt UPGRADING.txt README.FreeBSD \ @@ -37,22 +38,23 @@ post-patch: @${CP} ${PKGDIR}/files/README.FreeBSD ${WRKSRC}/docs/ - @${REINPLACE_CMD} -e "s|realpath('../')|'${PREFIX}/share'|g" \ + @${REINPLACE_CMD} -e "s|\$$basedir . 'adodb'| '${PREFIX}/share/adodb'|g" \ ${WRKSRC}/sql/install-${PORTVERSION}.php @${RM} ${WRKSRC}/sql/install-${PORTVERSION}.php.bak + @${RM} ${WRKSRC}/scripts/details.php.orig do-install: - @${MKDIR} ${PREFIX}/share/${PORTNAME} - ${CHMOD} 755 ${PREFIX}/share/${PORTNAME} - ${INSTALL_DATA} ${WRKSRC}/header.php ${PREFIX}/share/${PORTNAME}/header.php-dist + @${MKDIR} ${FLYSPRAYDIR} + ${CHMOD} 755 ${FLYSPRAYDIR} + ${INSTALL_DATA} ${WRKSRC}/header.php ${FLYSPRAYDIR}/header.php-dist cd ${WRKSRC} && \ tar cf - ${FLYSPRAY_FILES} | \ - (cd ${PREFIX}/share/${PORTNAME} && tar -xf -) - ${LN} -s ${DBDIR}/${PORTNAME}/attachments ${PREFIX}/share/${PORTNAME}/attachments + (cd ${FLYSPRAYDIR} && tar -xf -) + ${LN} -s ${DBDIR}/${PORTNAME}/attachments ${FLYSPRAYDIR}/attachments @${MKDIR} ${DBDIR}/${PORTNAME}/attachments ${CHMOD} 750 ${DBDIR}/${PORTNAME}/attachments ${CHOWN} ${WWWOWN}:${WWWGRP} ${DBDIR}/${PORTNAME}/attachments - ${CHOWN} ${WWWOWN}:${WWWGRP} ${PREFIX}/share/${PORTNAME} + ${CHOWN} ${WWWOWN}:${WWWGRP} ${FLYSPRAYDIR} post-install: install-doc @${SED} -e 's|%%DOCSDIR%%|${DOCSDIR}|g' pkg-message > ${PKGMESSAGE} diff -ur --new-file flyspray-0.9.7/files/patch-scripts::details.php flyspray/files/patch-scripts::details.php --- flyspray-0.9.7/files/patch-scripts::details.php Thu Jan 1 01:00:00 1970 +++ flyspray/files/patch-scripts::details.php Tue May 3 17:14:05 2005 @@ -0,0 +1,11 @@ +--- scripts/details.php.orig Tue May 3 17:13:21 2005 ++++ scripts/details.php Tue May 3 17:13:31 2005 +@@ -502,7 +502,7 @@ + </tr> + <tr> + <td><label for="percent"><?php echo $details_text['percentcomplete'];?></label></td> +- <td id="percent"><?php echo "<img src=\"themes/{$flyspray_prefs['theme_style']}/percent-{$task_details['percent_complete']}.png\" width=\"150\" height=\"10\" alt=\"{$task_details['percent_complete']}% {$details_text['complete']}\" title=\"{$task_details['percent_complete']}% {$details_text['complete']}\"";?> /></td> ++ <td id="percent"><?php echo "<img src=\"themes/{$project_prefs['theme_style']}/percent-{$task_details['percent_complete']}.png\" width=\"150\" height=\"10\" alt=\"{$task_details['percent_complete']}% {$details_text['complete']}\" title=\"{$task_details['percent_complete']}% {$details_text['complete']}\"";?> /></td> + </tr> + </table> +
The patch looks good, except two minor issues. - portlint complained about the patch file name. "Warning: files/patch-scripts::details.php: only use characters [-_.a-zA-Z0-9] for patch or script names." Maybe we should name it patch-scripts-details.php or something like that. - You defined a knob FLYSPRAYDIR which is the same with DATADIR. How about use the pre-defined DATADIR directly? -- Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan